Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread kbuild test robot
Hi Dima, [auto build test WARNING on v4.12] [cannot apply to cgroup/for-next linus/master v4.13-rc2 v4.13-rc1 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread kbuild test robot
Hi Dima, [auto build test WARNING on v4.12] [cannot apply to cgroup/for-next linus/master v4.13-rc2 v4.13-rc1 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Dima Zavin
On Fri, Jul 28, 2017 at 7:05 AM, Vlastimil Babka wrote: > On 07/28/2017 11:30 AM, Peter Zijlstra wrote: >> On Fri, Jul 28, 2017 at 09:45:16AM +0200, Vlastimil Babka wrote: >>> [+CC PeterZ] >>> >>> On 07/27/2017 06:46 PM, Dima Zavin wrote: In codepaths that use the begin/retry

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Dima Zavin
On Fri, Jul 28, 2017 at 7:05 AM, Vlastimil Babka wrote: > On 07/28/2017 11:30 AM, Peter Zijlstra wrote: >> On Fri, Jul 28, 2017 at 09:45:16AM +0200, Vlastimil Babka wrote: >>> [+CC PeterZ] >>> >>> On 07/27/2017 06:46 PM, Dima Zavin wrote: In codepaths that use the begin/retry interface for

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Vlastimil Babka
On 07/28/2017 11:30 AM, Peter Zijlstra wrote: > On Fri, Jul 28, 2017 at 09:45:16AM +0200, Vlastimil Babka wrote: >> [+CC PeterZ] >> >> On 07/27/2017 06:46 PM, Dima Zavin wrote: >>> In codepaths that use the begin/retry interface for reading >>> mems_allowed_seq with irqs disabled, there exists a

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Vlastimil Babka
On 07/28/2017 11:30 AM, Peter Zijlstra wrote: > On Fri, Jul 28, 2017 at 09:45:16AM +0200, Vlastimil Babka wrote: >> [+CC PeterZ] >> >> On 07/27/2017 06:46 PM, Dima Zavin wrote: >>> In codepaths that use the begin/retry interface for reading >>> mems_allowed_seq with irqs disabled, there exists a

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Peter Zijlstra
On Fri, Jul 28, 2017 at 09:45:16AM +0200, Vlastimil Babka wrote: > [+CC PeterZ] > > On 07/27/2017 06:46 PM, Dima Zavin wrote: > > In codepaths that use the begin/retry interface for reading > > mems_allowed_seq with irqs disabled, there exists a race condition that > > stalls the patch process

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Peter Zijlstra
On Fri, Jul 28, 2017 at 09:45:16AM +0200, Vlastimil Babka wrote: > [+CC PeterZ] > > On 07/27/2017 06:46 PM, Dima Zavin wrote: > > In codepaths that use the begin/retry interface for reading > > mems_allowed_seq with irqs disabled, there exists a race condition that > > stalls the patch process

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Dima Zavin
On Fri, Jul 28, 2017 at 12:45 AM, Vlastimil Babka wrote: > [+CC PeterZ] > > On 07/27/2017 06:46 PM, Dima Zavin wrote: >> In codepaths that use the begin/retry interface for reading >> mems_allowed_seq with irqs disabled, there exists a race condition that >> stalls the patch

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Dima Zavin
On Fri, Jul 28, 2017 at 12:45 AM, Vlastimil Babka wrote: > [+CC PeterZ] > > On 07/27/2017 06:46 PM, Dima Zavin wrote: >> In codepaths that use the begin/retry interface for reading >> mems_allowed_seq with irqs disabled, there exists a race condition that >> stalls the patch process after only

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Vlastimil Babka
[+CC PeterZ] On 07/27/2017 06:46 PM, Dima Zavin wrote: > In codepaths that use the begin/retry interface for reading > mems_allowed_seq with irqs disabled, there exists a race condition that > stalls the patch process after only modifying a subset of the > static_branch call sites. > > This

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-28 Thread Vlastimil Babka
[+CC PeterZ] On 07/27/2017 06:46 PM, Dima Zavin wrote: > In codepaths that use the begin/retry interface for reading > mems_allowed_seq with irqs disabled, there exists a race condition that > stalls the patch process after only modifying a subset of the > static_branch call sites. > > This

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Dima Zavin
On Thu, Jul 27, 2017 at 12:51 PM, Andrew Morton wrote: > On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > >> - Applied on top of v4.12 since one of the callers in page_alloc.c changed. >>Still only tested on v4.9.36 and compile tested

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Dima Zavin
On Thu, Jul 27, 2017 at 12:51 PM, Andrew Morton wrote: > On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > >> - Applied on top of v4.12 since one of the callers in page_alloc.c changed. >>Still only tested on v4.9.36 and compile tested against v4.12. > > That's a problem - this doesn't

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Dima Zavin
On Thu, Jul 27, 2017 at 12:48 PM, Andrew Morton wrote: > On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > >> In codepaths that use the begin/retry interface for reading >> mems_allowed_seq with irqs disabled, there exists a race condition that

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Dima Zavin
On Thu, Jul 27, 2017 at 12:48 PM, Andrew Morton wrote: > On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > >> In codepaths that use the begin/retry interface for reading >> mems_allowed_seq with irqs disabled, there exists a race condition that >> stalls the patch process after only

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Andrew Morton
On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > - Applied on top of v4.12 since one of the callers in page_alloc.c changed. >Still only tested on v4.9.36 and compile tested against v4.12. That's a problem - this doesn't come close to applying on current mainline.

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Andrew Morton
On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > - Applied on top of v4.12 since one of the callers in page_alloc.c changed. >Still only tested on v4.9.36 and compile tested against v4.12. That's a problem - this doesn't come close to applying on current mainline. I can fix that I

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Andrew Morton
On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > In codepaths that use the begin/retry interface for reading > mems_allowed_seq with irqs disabled, there exists a race condition that > stalls the patch process after only modifying a subset of the > static_branch call

Re: [PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Andrew Morton
On Thu, 27 Jul 2017 09:46:08 -0700 Dima Zavin wrote: > In codepaths that use the begin/retry interface for reading > mems_allowed_seq with irqs disabled, there exists a race condition that > stalls the patch process after only modifying a subset of the > static_branch call sites. > > This

[PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Dima Zavin
In codepaths that use the begin/retry interface for reading mems_allowed_seq with irqs disabled, there exists a race condition that stalls the patch process after only modifying a subset of the static_branch call sites. This problem manifested itself as a dead lock in the slub allocator, inside

[PATCH v2] cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()

2017-07-27 Thread Dima Zavin
In codepaths that use the begin/retry interface for reading mems_allowed_seq with irqs disabled, there exists a race condition that stalls the patch process after only modifying a subset of the static_branch call sites. This problem manifested itself as a dead lock in the slub allocator, inside