Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-25 Thread Matthias Kaehlcke
El Tue, Apr 25, 2017 at 07:06:30PM +0100 Ard Biesheuvel ha dit: > On 25 April 2017 at 18:39, Matthias Kaehlcke wrote: > > Hi, > > > > El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > > > >> On 18 April 2017 at 15:47, Paul Gortmaker

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-25 Thread Matthias Kaehlcke
El Tue, Apr 25, 2017 at 07:06:30PM +0100 Ard Biesheuvel ha dit: > On 25 April 2017 at 18:39, Matthias Kaehlcke wrote: > > Hi, > > > > El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > > > >> On 18 April 2017 at 15:47, Paul Gortmaker > >> wrote: > >> > On Wed, Apr 5, 2017 at

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-25 Thread Ard Biesheuvel
On 25 April 2017 at 18:39, Matthias Kaehlcke wrote: > Hi, > > El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > >> On 18 April 2017 at 15:47, Paul Gortmaker >> wrote: >> > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-25 Thread Ard Biesheuvel
On 25 April 2017 at 18:39, Matthias Kaehlcke wrote: > Hi, > > El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > >> On 18 April 2017 at 15:47, Paul Gortmaker >> wrote: >> > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke >> > wrote: >> >> The operand is an integer constant,

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-25 Thread Matthias Kaehlcke
Hi, El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > On 18 April 2017 at 15:47, Paul Gortmaker > wrote: > > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: > >> The operand is an integer constant, make the constness

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-25 Thread Matthias Kaehlcke
Hi, El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > On 18 April 2017 at 15:47, Paul Gortmaker > wrote: > > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: > >> The operand is an integer constant, make the constness explicit by > >> adding the modifier. This is

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Herbert Xu
On Mon, Apr 24, 2017 at 09:04:19AM +0100, Ard Biesheuvel wrote: > > Yes please. OK, patch reverted. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Herbert Xu
On Mon, Apr 24, 2017 at 09:04:19AM +0100, Ard Biesheuvel wrote: > > Yes please. OK, patch reverted. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Ard Biesheuvel
On 24 April 2017 at 09:00, Herbert Xu wrote: > On Tue, Apr 18, 2017 at 10:34:01AM -0700, Matthias Kaehlcke wrote: >> El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: >> >> > On 18 April 2017 at 15:47, Paul Gortmaker >> >

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Ard Biesheuvel
On 24 April 2017 at 09:00, Herbert Xu wrote: > On Tue, Apr 18, 2017 at 10:34:01AM -0700, Matthias Kaehlcke wrote: >> El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: >> >> > On 18 April 2017 at 15:47, Paul Gortmaker >> > wrote: >> > > On Wed, Apr 5, 2017 at 2:34 PM, Matthias

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Herbert Xu
On Tue, Apr 18, 2017 at 10:34:01AM -0700, Matthias Kaehlcke wrote: > El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > > > On 18 April 2017 at 15:47, Paul Gortmaker > > wrote: > > > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Herbert Xu
On Tue, Apr 18, 2017 at 10:34:01AM -0700, Matthias Kaehlcke wrote: > El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > > > On 18 April 2017 at 15:47, Paul Gortmaker > > wrote: > > > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke > > > wrote: > > >> The operand is an integer

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-18 Thread Matthias Kaehlcke
El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > On 18 April 2017 at 15:47, Paul Gortmaker > wrote: > > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: > >> The operand is an integer constant, make the constness

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-18 Thread Matthias Kaehlcke
El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > On 18 April 2017 at 15:47, Paul Gortmaker > wrote: > > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: > >> The operand is an integer constant, make the constness explicit by > >> adding the modifier. This is needed for

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-18 Thread Ard Biesheuvel
On 18 April 2017 at 15:47, Paul Gortmaker wrote: > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: >> The operand is an integer constant, make the constness explicit by >> adding the modifier. This is needed for clang to generate valid

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-18 Thread Ard Biesheuvel
On 18 April 2017 at 15:47, Paul Gortmaker wrote: > On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: >> The operand is an integer constant, make the constness explicit by >> adding the modifier. This is needed for clang to generate valid code >> and also works with gcc. > > Actually it

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-18 Thread Paul Gortmaker
On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: > The operand is an integer constant, make the constness explicit by > adding the modifier. This is needed for clang to generate valid code > and also works with gcc. Actually it doesn't work with all gcc. I've got an

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-18 Thread Paul Gortmaker
On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke wrote: > The operand is an integer constant, make the constness explicit by > adding the modifier. This is needed for clang to generate valid code > and also works with gcc. Actually it doesn't work with all gcc. I've got an older arm64

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-10 Thread Herbert Xu
On Wed, Apr 05, 2017 at 11:34:58AM -0700, Matthias Kaehlcke wrote: > The operand is an integer constant, make the constness explicit by > adding the modifier. This is needed for clang to generate valid code > and also works with gcc. > > Also change the constraint of the operand from 'I'

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-10 Thread Herbert Xu
On Wed, Apr 05, 2017 at 11:34:58AM -0700, Matthias Kaehlcke wrote: > The operand is an integer constant, make the constness explicit by > adding the modifier. This is needed for clang to generate valid code > and also works with gcc. > > Also change the constraint of the operand from 'I'

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 19:34, Matthias Kaehlcke wrote: > The operand is an integer constant, make the constness explicit by > adding the modifier. This is needed for clang to generate valid code > and also works with gcc. > > Also change the constraint of the operand from 'I'

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 19:34, Matthias Kaehlcke wrote: > The operand is an integer constant, make the constness explicit by > adding the modifier. This is needed for clang to generate valid code > and also works with gcc. > > Also change the constraint of the operand from 'I' ("Integer constant >

[PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-05 Thread Matthias Kaehlcke
The operand is an integer constant, make the constness explicit by adding the modifier. This is needed for clang to generate valid code and also works with gcc. Also change the constraint of the operand from 'I' ("Integer constant that is valid as an immediate operand in an ADD instruction",

[PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-05 Thread Matthias Kaehlcke
The operand is an integer constant, make the constness explicit by adding the modifier. This is needed for clang to generate valid code and also works with gcc. Also change the constraint of the operand from 'I' ("Integer constant that is valid as an immediate operand in an ADD instruction",