Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

2018-01-12 Thread Joey Pabalinas
On Fri, Jan 12, 2018 at 11:23:28PM +1100, Herbert Xu wrote: > > Patch applied. Thanks. No problem, cheers. -- Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

2018-01-12 Thread Joey Pabalinas
On Fri, Jan 12, 2018 at 11:23:28PM +1100, Herbert Xu wrote: > > Patch applied. Thanks. No problem, cheers. -- Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

2018-01-12 Thread Herbert Xu
On Mon, Jan 01, 2018 at 10:40:14AM -1000, Joey Pabalinas wrote: > When char is signed, storing the values 0xba (186) and 0xad (173) in the > `guard` array produces signed overflow. Change the type of `guard` to > static unsigned char to correct undefined behavior and reduce function > stack usage.

Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

2018-01-12 Thread Herbert Xu
On Mon, Jan 01, 2018 at 10:40:14AM -1000, Joey Pabalinas wrote: > When char is signed, storing the values 0xba (186) and 0xad (173) in the > `guard` array produces signed overflow. Change the type of `guard` to > static unsigned char to correct undefined behavior and reduce function > stack usage.

[PATCH v2] crypto: testmgr: change `guard` to unsigned char

2018-01-01 Thread Joey Pabalinas
When char is signed, storing the values 0xba (186) and 0xad (173) in the `guard` array produces signed overflow. Change the type of `guard` to static unsigned char to correct undefined behavior and reduce function stack usage. Signed-off-by: Joey Pabalinas ---

[PATCH v2] crypto: testmgr: change `guard` to unsigned char

2018-01-01 Thread Joey Pabalinas
When char is signed, storing the values 0xba (186) and 0xad (173) in the `guard` array produces signed overflow. Change the type of `guard` to static unsigned char to correct undefined behavior and reduce function stack usage. Signed-off-by: Joey Pabalinas --- crypto/testmgr.c | 2 +- 1 file