Re: [PATCH v2] dma-mapping: add unlikely hint for error path in dma_mapping_error

2021-01-08 Thread Heiner Kallweit
On 14.12.2020 14:01, Robin Murphy wrote: > On 2020-12-13 16:32, Heiner Kallweit wrote: >> Zillions of drivers use the unlikely() hint when checking the result of >> dma_mapping_error(). This is an inline function anyway, so we can move >> the hint into this function and remove it from drivers. > >

Re: [PATCH v2] dma-mapping: add unlikely hint for error path in dma_mapping_error

2020-12-14 Thread Robin Murphy
On 2020-12-13 16:32, Heiner Kallweit wrote: Zillions of drivers use the unlikely() hint when checking the result of dma_mapping_error(). This is an inline function anyway, so we can move the hint into this function and remove it from drivers. Reviewed-by: Robin Murphy FWIW I consider this cas

Re: [PATCH v2] dma-mapping: add unlikely hint for error path in dma_mapping_error

2020-12-13 Thread Heiner Kallweit
Bao Hua >> (Barry Song) >> Cc: open list:AMD IOMMU (AMD-VI) ; Linux >> Kernel Mailing List >> Subject: [PATCH v2] dma-mapping: add unlikely hint for error path in >> dma_mapping_error >> >> Zillions of drivers use the unlikely() hint when checking the resul

RE: [PATCH v2] dma-mapping: add unlikely hint for error path in dma_mapping_error

2020-12-13 Thread Song Bao Hua (Barry Song)
Mailing List > Subject: [PATCH v2] dma-mapping: add unlikely hint for error path in > dma_mapping_error > > Zillions of drivers use the unlikely() hint when checking the result of > dma_mapping_error(). This is an inline function anyway, so we can move > the hint into this function a

[PATCH v2] dma-mapping: add unlikely hint for error path in dma_mapping_error

2020-12-13 Thread Heiner Kallweit
Zillions of drivers use the unlikely() hint when checking the result of dma_mapping_error(). This is an inline function anyway, so we can move the hint into this function and remove it from drivers. Signed-off-by: Heiner Kallweit --- v2: Split the big patch into the change for dma-mapping.h and f