Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-04-05 Thread Evan Benn
On Sat, Apr 3, 2021 at 1:15 AM Daniel Lezcano wrote: > > > > That said I am happy to upload that version if people think it is better. > > IMO, it is not in the normal flow to disable/enable the interrupts. Hi Daniel, no problem. I will upload the suspend/resume version. Please note the similar

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-04-02 Thread Daniel Lezcano
Hi Evan, On 27/03/2021 02:31, Evan Benn wrote: > Hi Daniel, > > That is a good point, and I did try that at first and it works fine. I > uploaded this version because the suspend/resume callbacks were > undocumented and mostly not used by other clocksource drivers. I > thought a smaller diff mi

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-03-26 Thread Evan Benn
Hi Daniel, That is a good point, and I did try that at first and it works fine. I uploaded this version because the suspend/resume callbacks were undocumented and mostly not used by other clocksource drivers. I thought a smaller diff might be preferable. I also thought it would be better to shut o

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-03-25 Thread Daniel Lezcano
On 25/03/2021 02:35, Evan Benn wrote: > set_state_shutdown is called during system suspend after interrupts have > been disabled. If the timer has fired in the meantime, there will be > a pending IRQ. So we ack that now and disable the timer. Without this > ARM trusted firmware will abort the suspe

[PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-03-24 Thread Evan Benn
set_state_shutdown is called during system suspend after interrupts have been disabled. If the timer has fired in the meantime, there will be a pending IRQ. So we ack that now and disable the timer. Without this ARM trusted firmware will abort the suspend due to the pending interrupt. Now always d