Re: Fwd: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-24 Thread Sylwester Nawrocki
On 09/23/2012 09:30 PM, Mauro Carvalho Chehab wrote: > Sylwester, > > Please review. > > Regards, > Mauro > > Mensagem original -------- > Assunto: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return > code > Data: Thu, 6 Sep 2012

Re: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-24 Thread Tomasz Stanislawski
Hi. On 09/06/2012 10:38 AM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows:

Re: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-24 Thread Tomasz Stanislawski
Hi. On 09/06/2012 10:38 AM, Peter Senna Tschudin wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows:

Re: Fwd: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-24 Thread Sylwester Nawrocki
On 09/23/2012 09:30 PM, Mauro Carvalho Chehab wrote: Sylwester, Please review. Regards, Mauro Mensagem original Assunto: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code Data: Thu, 6 Sep 2012 10:38:29 +0200 De: Peter Senna Tschudin

Fwd: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-23 Thread Mauro Carvalho Chehab
Sylwester, Please review. Regards, Mauro Mensagem original Assunto: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code Data: Thu, 6 Sep 2012 10:38:29 +0200 De: Peter Senna Tschudin Para: peter.se...@gmail.com, Mauro Carvalho Chehab CC: linux-me

Fwd: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-23 Thread Mauro Carvalho Chehab
Sylwester, Please review. Regards, Mauro Mensagem original Assunto: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code Data: Thu, 6 Sep 2012 10:38:29 +0200 De: Peter Senna Tschudin peter.se...@gmail.com Para: peter.se...@gmail.com, Mauro Carvalho

[PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret !=