Re: [PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement

2015-06-26 Thread Dan Carpenter
On Fri, Jun 26, 2015 at 06:35:11PM +0530, Sunil Shahu wrote: > Hi Dan, > > On Mon, 2015-06-22 at 20:34 +0300, Dan Carpenter wrote: > > > + u32 c = 0x1234; > > ^^ > > In another follow on patch you can get rid of this. It is nonsense > > and > > it isn't used. > >

Re: [PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement

2015-06-26 Thread Sunil Shahu
Hi Dan, On Mon, 2015-06-22 at 20:34 +0300, Dan Carpenter wrote: > > + u32 c = 0x1234; > ^^ > In another follow on patch you can get rid of this. It is nonsense > and > it isn't used. By "follow on patch", did you mean that I should send v3 revision of my patch or

Re: [PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement

2015-06-22 Thread Dan Carpenter
On Mon, Jun 22, 2015 at 04:58:41PM +0530, Sunil Shahu wrote: > "else" statement after "if" is unnecessary, hence removed. > > Signed-off-by: Sunil Shahu > --- > drivers/staging/rtl8712/rtl871x_security.c | 35 > ++ > 1 file changed, 16 insertions(+), 19 deletions(-)

[PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement

2015-06-22 Thread Sunil Shahu
"else" statement after "if" is unnecessary, hence removed. Signed-off-by: Sunil Shahu --- drivers/staging/rtl8712/rtl871x_security.c | 35 ++ 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/