Re: [PATCH v2] drm/color: Document CTM eqations

On Fri, Feb 17, 2017 at 01:54:52PM +, Brian Starkey wrote: > What's the verdict? We've got [1] which is about to become another > (driver) implementation - better to change before that merges than > after I guess. We could also just switch the internal representation to something more

Re: [PATCH v2] drm/color: Document CTM eqations

On Fri, Feb 17, 2017 at 01:54:52PM +, Brian Starkey wrote: > What's the verdict? We've got [1] which is about to become another > (driver) implementation - better to change before that merges than > after I guess. We could also just switch the internal representation to something more

Re: [PATCH v2] drm/color: Document CTM eqations

On Fri, Feb 17, 2017 at 03:05:28PM +, Lionel Landwerlin wrote: > On 17/02/17 14:56, Ville Syrjälä wrote: > > On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: > >> On 17/02/17 13:54, Brian Starkey wrote: > >>> What's the verdict? We've got [1] which is about to become another

Re: [PATCH v2] drm/color: Document CTM eqations

On Fri, Feb 17, 2017 at 03:05:28PM +, Lionel Landwerlin wrote: > On 17/02/17 14:56, Ville Syrjälä wrote: > > On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: > >> On 17/02/17 13:54, Brian Starkey wrote: > >>> What's the verdict? We've got [1] which is about to become another

Re: [PATCH v2] drm/color: Document CTM eqations

Hi, On 17 February 2017 at 14:56, Ville Syrjälä wrote: > On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: >> If we're talking fixed point reprsentation, ChromeOS is using this : >> >>

Re: [PATCH v2] drm/color: Document CTM eqations

Hi, On 17 February 2017 at 14:56, Ville Syrjälä wrote: > On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: >> If we're talking fixed point reprsentation, ChromeOS is using this : >> >> https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/gpu/drm_device.cc?q=DrmDevice=209 >

Re: [PATCH v2] drm/color: Document CTM eqations

On 17/02/17 14:56, Ville Syrjälä wrote: On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: On 17/02/17 13:54, Brian Starkey wrote: What's the verdict? We've got [1] which is about to become another (driver) implementation - better to change before that merges than after I

Re: [PATCH v2] drm/color: Document CTM eqations

On 17/02/17 14:56, Ville Syrjälä wrote: On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: On 17/02/17 13:54, Brian Starkey wrote: What's the verdict? We've got [1] which is about to become another (driver) implementation - better to change before that merges than after I

Re: [PATCH v2] drm/color: Document CTM eqations

On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: > On 17/02/17 13:54, Brian Starkey wrote: > > What's the verdict? We've got [1] which is about to become another > > (driver) implementation - better to change before that merges than > > after I guess. > > > > -Brian > > > > [1]

Re: [PATCH v2] drm/color: Document CTM eqations

On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: > On 17/02/17 13:54, Brian Starkey wrote: > > What's the verdict? We've got [1] which is about to become another > > (driver) implementation - better to change before that merges than > > after I guess. > > > > -Brian > > > > [1]

Re: [PATCH v2] drm/color: Document CTM eqations

On 17/02/17 13:54, Brian Starkey wrote: What's the verdict? We've got [1] which is about to become another (driver) implementation - better to change before that merges than after I guess. -Brian [1] https://lkml.org/lkml/2017/2/13/304 On Wed, Feb 15, 2017 at 11:56:55AM +, Daniel Stone

Re: [PATCH v2] drm/color: Document CTM eqations

On 17/02/17 13:54, Brian Starkey wrote: What's the verdict? We've got [1] which is about to become another (driver) implementation - better to change before that merges than after I guess. -Brian [1] https://lkml.org/lkml/2017/2/13/304 On Wed, Feb 15, 2017 at 11:56:55AM +, Daniel Stone

Re: [PATCH v2] drm/color: Document CTM eqations

What's the verdict? We've got [1] which is about to become another (driver) implementation - better to change before that merges than after I guess. -Brian [1] https://lkml.org/lkml/2017/2/13/304 On Wed, Feb 15, 2017 at 11:56:55AM +, Daniel Stone wrote: Hi, On 15 February 2017 at 11:39,

Re: [PATCH v2] drm/color: Document CTM eqations

What's the verdict? We've got [1] which is about to become another (driver) implementation - better to change before that merges than after I guess. -Brian [1] https://lkml.org/lkml/2017/2/13/304 On Wed, Feb 15, 2017 at 11:56:55AM +, Daniel Stone wrote: Hi, On 15 February 2017 at 11:39,

Re: [PATCH v2] drm/color: Document CTM eqations

Hi, On 15 February 2017 at 11:39, Ville Syrjälä wrote: > On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote: >> On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä >> wrote: >> > Hmm. Two's complement is what I was thinking it

Re: [PATCH v2] drm/color: Document CTM eqations

Hi, On 15 February 2017 at 11:39, Ville Syrjälä wrote: > On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote: >> On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä >> wrote: >> > Hmm. Two's complement is what I was thinking it is. Which shows that >> > I never managed to read the code in

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote: > On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä > wrote: > >> >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > >> >> index ce7efe2e8a5e..3401637caf8e 100644 > >> >> ---

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote: > On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä > wrote: > >> >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > >> >> index ce7efe2e8a5e..3401637caf8e 100644 > >> >> --- a/include/uapi/drm/drm_mode.h > >> >>

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 03:39:29PM +, Brian Starkey wrote: > Hi Ville, > > On Tue, Jan 31, 2017 at 05:18:28PM +0200, Ville Syrjälä wrote: > >On Tue, Jan 31, 2017 at 10:48:34AM +, Brian Starkey wrote: > >> Explicitly state the expected CTM equations in the kerneldoc for the CTM > >>

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 03:39:29PM +, Brian Starkey wrote: > Hi Ville, > > On Tue, Jan 31, 2017 at 05:18:28PM +0200, Ville Syrjälä wrote: > >On Tue, Jan 31, 2017 at 10:48:34AM +, Brian Starkey wrote: > >> Explicitly state the expected CTM equations in the kerneldoc for the CTM > >>

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä wrote: >> >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h >> >> index ce7efe2e8a5e..3401637caf8e 100644 >> >> --- a/include/uapi/drm/drm_mode.h >> >> +++ b/include/uapi/drm/drm_mode.h >> >> @@

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä wrote: >> >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h >> >> index ce7efe2e8a5e..3401637caf8e 100644 >> >> --- a/include/uapi/drm/drm_mode.h >> >> +++ b/include/uapi/drm/drm_mode.h >> >> @@ -525,7 +525,13 @@ struct

Re: [PATCH v2] drm/color: Document CTM eqations

Hi Ville, On Tue, Jan 31, 2017 at 05:18:28PM +0200, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 10:48:34AM +, Brian Starkey wrote: Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä

Re: [PATCH v2] drm/color: Document CTM eqations

Hi Ville, On Tue, Jan 31, 2017 at 05:18:28PM +0200, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 10:48:34AM +, Brian Starkey wrote: Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc:

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 10:48:34AM +, Brian Starkey wrote: > Explicitly state the expected CTM equations in the kerneldoc for the CTM > property, and the form of the matrix on struct drm_color_ctm. > > Cc: Ville Syrjälä > Cc: Lionel Landwerlin

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, Jan 31, 2017 at 10:48:34AM +, Brian Starkey wrote: > Explicitly state the expected CTM equations in the kerneldoc for the CTM > property, and the form of the matrix on struct drm_color_ctm. > > Cc: Ville Syrjälä > Cc: Lionel Landwerlin > Cc: Daniel Vetter > Signed-off-by: Brian

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, 31 Jan 2017, Brian Starkey wrote: > Hi Jani, > > On Tue, Jan 31, 2017 at 01:30:41PM +0200, Jani Nikula wrote: >>On Tue, 31 Jan 2017, Brian Starkey wrote: >>> Explicitly state the expected CTM equations in the kerneldoc for the CTM >>>

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, 31 Jan 2017, Brian Starkey wrote: > Hi Jani, > > On Tue, Jan 31, 2017 at 01:30:41PM +0200, Jani Nikula wrote: >>On Tue, 31 Jan 2017, Brian Starkey wrote: >>> Explicitly state the expected CTM equations in the kerneldoc for the CTM >>> property, and the form of the matrix on struct

Re: [PATCH v2] drm/color: Document CTM eqations

Hi Jani, On Tue, Jan 31, 2017 at 01:30:41PM +0200, Jani Nikula wrote: On Tue, 31 Jan 2017, Brian Starkey wrote: Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä

Re: [PATCH v2] drm/color: Document CTM eqations

Hi Jani, On Tue, Jan 31, 2017 at 01:30:41PM +0200, Jani Nikula wrote: On Tue, 31 Jan 2017, Brian Starkey wrote: Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc: Lionel Landwerlin Cc:

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, 31 Jan 2017, Brian Starkey wrote: > Explicitly state the expected CTM equations in the kerneldoc for the CTM > property, and the form of the matrix on struct drm_color_ctm. > > Cc: Ville Syrjälä > Cc: Lionel Landwerlin

Re: [PATCH v2] drm/color: Document CTM eqations

On Tue, 31 Jan 2017, Brian Starkey wrote: > Explicitly state the expected CTM equations in the kerneldoc for the CTM > property, and the form of the matrix on struct drm_color_ctm. > > Cc: Ville Syrjälä > Cc: Lionel Landwerlin > Cc: Daniel Vetter > Signed-off-by: Brian Starkey > --- >

[PATCH v2] drm/color: Document CTM eqations

Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc: Lionel Landwerlin Cc: Daniel Vetter Signed-off-by:

[PATCH v2] drm/color: Document CTM eqations

Explicitly state the expected CTM equations in the kerneldoc for the CTM property, and the form of the matrix on struct drm_color_ctm. Cc: Ville Syrjälä Cc: Lionel Landwerlin Cc: Daniel Vetter Signed-off-by: Brian Starkey --- drivers/gpu/drm/drm_color_mgmt.c | 13 +