Re: [PATCH v2] drm/i2c: tda998x: Change the compatible strings

2014-03-23 Thread Sebastian Hesselbarth
On 03/23/2014 09:03 PM, Russell King - ARM Linux wrote: On Sun, Mar 23, 2014 at 07:12:05PM +0100, Sebastian Hesselbarth wrote: On 03/23/2014 11:19 AM, Jean-Francois Moine wrote: On Fri, 21 Mar 2014 14:37:52 +0100 Sebastian Hesselbarth wrote: Required properties; - - compatible: must be "

Re: [PATCH v2] drm/i2c: tda998x: Change the compatible strings

2014-03-23 Thread Russell King - ARM Linux
On Sun, Mar 23, 2014 at 07:12:05PM +0100, Sebastian Hesselbarth wrote: > On 03/23/2014 11:19 AM, Jean-Francois Moine wrote: >> On Fri, 21 Mar 2014 14:37:52 +0100 >> Sebastian Hesselbarth wrote: Required properties; - - compatible: must be "nxp,tda998x" + - compatible: may be "n

Re: [PATCH v2] drm/i2c: tda998x: Change the compatible strings

2014-03-23 Thread Sebastian Hesselbarth
On 03/23/2014 11:19 AM, Jean-Francois Moine wrote: On Fri, 21 Mar 2014 14:37:52 +0100 Sebastian Hesselbarth wrote: Required properties; - - compatible: must be "nxp,tda998x" + - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989" There is a "DT is ABI" policy and although

Re: [PATCH v2] drm/i2c: tda998x: Change the compatible strings

2014-03-23 Thread Jean-Francois Moine
On Fri, 21 Mar 2014 14:37:52 +0100 Sebastian Hesselbarth wrote: > > Required properties; > > - - compatible: must be "nxp,tda998x" > > + - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989" > > There is a "DT is ABI" policy and although there is no mainline Linux > user of

Re: [PATCH v2] drm/i2c: tda998x: Change the compatible strings

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 11:55 AM, Jean-Francois Moine wrote: The tda998x driver accepts only 3 chips from the TDA998x family. This patch changes the driver compatible strings to these chips. Jean-Francois, be careful with building a DT binding from a Linux driver. Although we constantly struggle to defi

[PATCH v2] drm/i2c: tda998x: Change the compatible strings

2014-03-21 Thread Jean-Francois Moine
The tda998x driver accepts only 3 chips from the TDA998x family. This patch changes the driver compatible strings to these chips. Signed-off-by: Jean-Francois Moine --- v2: change the subject to drm/i2c This patch applies after drm/i2c: tda998x: Fix lack of required reg in DT documentatio