Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
On Wed, Nov 23, 2016 at 02:47:53PM +0200, Jani Nikula wrote: > On Wed, 23 Nov 2016, Daniel Vetter wrote: > > On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: > >> On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > >> > On Wed, 23 Nov 2016, Liviu Dudau

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
On Wed, Nov 23, 2016 at 02:47:53PM +0200, Jani Nikula wrote: > On Wed, 23 Nov 2016, Daniel Vetter wrote: > > On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: > >> On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > >> > On Wed, 23 Nov 2016, Liviu Dudau wrote: > >> > >

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
On Wed, 23 Nov 2016, Daniel Vetter wrote: > On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: >> On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: >> > On Wed, 23 Nov 2016, Liviu Dudau wrote: >> > > drm_get_format_name() de-references

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
On Wed, 23 Nov 2016, Daniel Vetter wrote: > On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: >> On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: >> > On Wed, 23 Nov 2016, Liviu Dudau wrote: >> > > drm_get_format_name() de-references the buf parameter without checking >> >

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Daniel Vetter
On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: > On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > > On Wed, 23 Nov 2016, Liviu Dudau wrote: > > > drm_get_format_name() de-references the buf parameter without checking > > > if the pointer was not

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Daniel Vetter
On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: > On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > > On Wed, 23 Nov 2016, Liviu Dudau wrote: > > > drm_get_format_name() de-references the buf parameter without checking > > > if the pointer was not NULL. Given that the

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > On Wed, 23 Nov 2016, Liviu Dudau wrote: > > drm_get_format_name() de-references the buf parameter without checking > > if the pointer was not NULL. Given that the function is EXPORT-ed, lets > > sanitise the

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > On Wed, 23 Nov 2016, Liviu Dudau wrote: > > drm_get_format_name() de-references the buf parameter without checking > > if the pointer was not NULL. Given that the function is EXPORT-ed, lets > > sanitise the parameters before

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
On Wed, 23 Nov 2016, Liviu Dudau wrote: > drm_get_format_name() de-references the buf parameter without checking > if the pointer was not NULL. Given that the function is EXPORT-ed, lets > sanitise the parameters before proceeding. > > v2: Use BUG_ON() to annoy users that did

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
On Wed, 23 Nov 2016, Liviu Dudau wrote: > drm_get_format_name() de-references the buf parameter without checking > if the pointer was not NULL. Given that the function is EXPORT-ed, lets > sanitise the parameters before proceeding. > > v2: Use BUG_ON() to annoy users that did not pass valid

[PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
drm_get_format_name() de-references the buf parameter without checking if the pointer was not NULL. Given that the function is EXPORT-ed, lets sanitise the parameters before proceeding. v2: Use BUG_ON() to annoy users that did not pass valid parameters to function. Fixes: b3c11ac267d461d3d5

[PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
drm_get_format_name() de-references the buf parameter without checking if the pointer was not NULL. Given that the function is EXPORT-ed, lets sanitise the parameters before proceeding. v2: Use BUG_ON() to annoy users that did not pass valid parameters to function. Fixes: b3c11ac267d461d3d5