Re: [PATCH v2] drm: fix off-by-one in logger

2018-05-23 Thread Norbert Manthey
Dear all, I just noticed that replying to my earlier email thread failed, and that I thereby created a new thread. The original thread is the following one: https://lkml.org/lkml/2018/2/16/274 I am sorry for the confusion! Best, Norbert On 05/23/2018 08:22 AM, Norbert Manthey wrote: > The curr

[PATCH v2] drm: fix off-by-one in logger

2018-05-22 Thread Norbert Manthey
The current implementation will leak a byte to the log via memmove. The specified 27 bytes are off-by-one, as the payload is 25 bytes, and the termination character is only one byte large. To avoid this, factor out the error message, and furthermore make the second parameter of the append_entry fun