Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2015 at 10:12:16AM +, John Keeping wrote: > On Tue, 17 Nov 2015 20:11:23 +0100, Daniel Vetter wrote: > > > On Tue, Nov 17, 2015 at 06:47:28PM +, John Keeping wrote: > > > On Tue, 17 Nov 2015 19:31:32 +0100, Daniel Vetter wrote: > > > > > > > On Tue, Nov 17, 2015 at 12:07

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread John Keeping
On Tue, 17 Nov 2015 20:11:23 +0100, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 06:47:28PM +, John Keeping wrote: > > On Tue, 17 Nov 2015 19:31:32 +0100, Daniel Vetter wrote: > > > > > On Tue, Nov 17, 2015 at 12:07:24PM -0500, Alex Deucher wrote: > > > > On Tue, Nov 17, 2015 at 11:29 A

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Michel Dänzer
On 18.11.2015 17:51, Daniel Vetter wrote: > On Wed, Nov 18, 2015 at 05:39:39PM +0900, Michel Dänzer wrote: >> On 18.11.2015 01:29, Daniel Vetter wrote: >>> >>> And no, I have absolutely no idea why radeon is pulling some tricks here, >>> which have been added in >>> >>> commit 78b1a6010b46a69bcd47b

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2015 at 05:39:39PM +0900, Michel Dänzer wrote: > On 18.11.2015 01:29, Daniel Vetter wrote: > > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: > >> On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: > >> > >>> On Tue, Nov 17, 2015 at 03:05:34PM +, John Keepin

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Michel Dänzer
On 18.11.2015 01:29, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: >> On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: >> >>> On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: The request's hot_x and hot_y are set correctly for both >>

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Alex Deucher
On Tue, Nov 17, 2015 at 1:40 PM, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 04:58:06PM +, John Keeping wrote: >> On Tue, 17 Nov 2015 17:29:35 +0100, Daniel Vetter wrote: >> >> > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: >> > > On Tue, 17 Nov 2015 17:39:32 +0200, Ville S

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2015 at 06:47:28PM +, John Keeping wrote: > On Tue, 17 Nov 2015 19:31:32 +0100, Daniel Vetter wrote: > > > On Tue, Nov 17, 2015 at 12:07:24PM -0500, Alex Deucher wrote: > > > On Tue, Nov 17, 2015 at 11:29 AM, Daniel Vetter > > > wrote: > > > > On Tue, Nov 17, 2015 at 03:59:4

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread John Keeping
On Tue, 17 Nov 2015 19:31:32 +0100, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 12:07:24PM -0500, Alex Deucher wrote: > > On Tue, Nov 17, 2015 at 11:29 AM, Daniel Vetter > > wrote: > > > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: > > >> On Tue, 17 Nov 2015 17:39:32 +0200

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2015 at 04:58:06PM +, John Keeping wrote: > On Tue, 17 Nov 2015 17:29:35 +0100, Daniel Vetter wrote: > > > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: > > > On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: > > > > > > > On Tue, Nov 17, 2015 at 03:05

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2015 at 12:07:24PM -0500, Alex Deucher wrote: > On Tue, Nov 17, 2015 at 11:29 AM, Daniel Vetter wrote: > > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: > >> On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: > >> > >> > On Tue, Nov 17, 2015 at 03:05:34PM +000

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Alex Deucher
On Tue, Nov 17, 2015 at 11:29 AM, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: >> On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: >> >> > On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: >> > > The request's hot_x and hot_y are set corr

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread John Keeping
On Tue, 17 Nov 2015 17:29:35 +0100, Daniel Vetter wrote: > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: > > On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: > > > > > On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: > > > > The request's hot_x and hot_y a

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: > On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: > > > On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: > > > The request's hot_x and hot_y are set correctly for both > > > DRM_IOCTL_MODE_CURSOR and DRM_IOCTL_MODE

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Ville Syrjälä
On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote: > On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: > > > On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: > > > The request's hot_x and hot_y are set correctly for both > > > DRM_IOCTL_MODE_CURSOR and DRM_IOCTL_MODE

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread John Keeping
On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote: > On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: > > The request's hot_x and hot_y are set correctly for both > > DRM_IOCTL_MODE_CURSOR and DRM_IOCTL_MODE_CURSOR2 so we just need to > > save the values and then apply the offse

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread Ville Syrjälä
On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote: > The request's hot_x and hot_y are set correctly for both > DRM_IOCTL_MODE_CURSOR and DRM_IOCTL_MODE_CURSOR2 so we just need to save > the values and then apply the offset to the cursor plane when the cursor > moves. > > Signed-off-by:

[PATCH v2] drm: support hotspot for universal plane cursors

2015-11-17 Thread John Keeping
The request's hot_x and hot_y are set correctly for both DRM_IOCTL_MODE_CURSOR and DRM_IOCTL_MODE_CURSOR2 so we just need to save the values and then apply the offset to the cursor plane when the cursor moves. Signed-off-by: John Keeping --- v2: - add kerneldoc for hot_x and hot_y in struct drm