Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry

2023-10-30 Thread Naresh Kamboju
On Mon, 30 Oct 2023 at 20:11, Steven Rostedt wrote: > > On Mon, 30 Oct 2023 12:37:08 +0530 > Naresh Kamboju wrote: > > > > > I have tested the linux-trace.git trace/core and run selftests ftrace > > the reported kernel panic [1] & [2] has been fixed but found > > Good to know. Can I add

Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry

2023-10-30 Thread Steven Rostedt
On Mon, 30 Oct 2023 12:37:08 +0530 Naresh Kamboju wrote: > > I have tested the linux-trace.git trace/core and run selftests ftrace > the reported kernel panic [1] & [2] has been fixed but found Good to know. Can I add "Tested-by" from you for that bug fix? > "general protection fault" at

Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry

2023-10-30 Thread Naresh Kamboju
Hi Steven, > Are you sure it was applied correctly? Please ignore the build warnings / errors it was due to apply patch was not successful. > Perhaps check out the branch I > have and let me know if you get the same errors. > > git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git

Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry

2023-10-29 Thread Steven Rostedt
On Sun, 29 Oct 2023 12:31:54 +0530 Naresh Kamboju wrote: > Following build errors have been noticed. > > fs/tracefs/event_inode.c:348:1: error: return type defaults to 'int' > [-Werror=implicit-int] > 348 | create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei, > |

Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry

2023-10-29 Thread Naresh Kamboju
On Sun, 29 Oct 2023 at 02:16, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > The eventfs_inode (ei) is protected by SRCU, but the ei->dentry is not. It > is protected by the eventfs_mutex. Anytime the eventfs_mutex is released, > and access to the ei->dentry needs to be done, it

Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry

2023-10-28 Thread Google
On Sat, 28 Oct 2023 16:46:50 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The eventfs_inode (ei) is protected by SRCU, but the ei->dentry is not. It > is protected by the eventfs_mutex. Anytime the eventfs_mutex is released, > and access to the ei->dentry needs to be done,

[PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry

2023-10-28 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The eventfs_inode (ei) is protected by SRCU, but the ei->dentry is not. It is protected by the eventfs_mutex. Anytime the eventfs_mutex is released, and access to the ei->dentry needs to be done, it should first check if ei->is_freed is set under the