Re: [PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-11 Thread Markus Elfring
… > +++ b/fs/exfat/namei.c > @@ -1077,10 +1077,14 @@ static int exfat_rename_file(struct inode *inode, > struct exfat_chain *p_dir, > > epold = exfat_get_dentry(sb, p_dir, oldentry + 1, _bh, > _old); > + if (!epold) > + return

Re: [PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-11 Thread Markus Elfring
… > +++ b/fs/exfat/namei.c > @@ -1077,10 +1077,14 @@ static int exfat_rename_file(struct inode *inode, > struct exfat_chain *p_dir, > > epold = exfat_get_dentry(sb, p_dir, oldentry + 1, _bh, > _old); > + if (!epold) > + return

RE: [PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-10 Thread Namjae Jeon
> If the second exfat_get_dentry() call fails then we need to release "old_bh" > before returning. There > is a similar bug in exfat_move_file(). > > Fixes: 5f2aa075070c ("exfat: add inode operations") > Reported-by: Markus Elfring > Signed-off-by: Dan Carpenter Applied. Thanks!

Re: [PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-10 Thread Matthew Wilcox
On Wed, Jun 10, 2020 at 08:56:26PM +0200, Markus Elfring wrote: > >>> If the second exfat_get_dentry() call fails then we need to release > >>> "old_bh" before returning. There is a similar bug in exfat_move_file(). > >> > >> Would you like to convert any information from this change description

Re: [PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-10 Thread Markus Elfring
>>> If the second exfat_get_dentry() call fails then we need to release >>> "old_bh" before returning. There is a similar bug in exfat_move_file(). >> >> Would you like to convert any information from this change description >> into an imperative wording? >>

Re: [PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-10 Thread Dan Carpenter
On Wed, Jun 10, 2020 at 08:12:46PM +0200, Markus Elfring wrote: > > If the second exfat_get_dentry() call fails then we need to release > > "old_bh" before returning. There is a similar bug in exfat_move_file(). > > Would you like to convert any information from this change description > into an

Re: [PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-10 Thread Markus Elfring
> If the second exfat_get_dentry() call fails then we need to release > "old_bh" before returning. There is a similar bug in exfat_move_file(). Would you like to convert any information from this change description into an imperative wording?

[PATCH v2] exfat: add missing brelse() calls on error paths

2020-06-10 Thread Dan Carpenter
If the second exfat_get_dentry() call fails then we need to release "old_bh" before returning. There is a similar bug in exfat_move_file(). Fixes: 5f2aa075070c ("exfat: add inode operations") Reported-by: Markus Elfring Signed-off-by: Dan Carpenter --- v2: fix exfat_move_file() as well. Also