Re: [PATCH v2] ext4: fix hole punch failure when depth is greater than 0

2012-07-09 Thread Ashish Sangwan
> Ok, the code is not very clear, but now I can see it. p_block is > actually misused here to store the number of indexes in the current > node while diving into the tree. Then on the way up, we are checking > that to see if the eh_entries changed or not (which is indicating > that something has

Re: [PATCH v2] ext4: fix hole punch failure when depth is greater than 0

2012-07-09 Thread Lukáš Czerner
On Thu, 5 Jul 2012, Ashish Sangwan wrote: > Date: Thu, 5 Jul 2012 15:22:04 +0530 > From: Ashish Sangwan > To: Lukáš Czerner > Cc: sand...@redhat.com, Ted Tso , linux-kernel@vger.kernel.org, > linux-e...@vger.kernel.org, Namjae Jeon > Subject: Re: [PATCH v2] ext4: fix

Re: [PATCH v2] ext4: fix hole punch failure when depth is greater than 0

2012-07-09 Thread Lukáš Czerner
...@gmail.com Subject: Re: [PATCH v2] ext4: fix hole punch failure when depth is greater than 0 On Wed, Jul 4, 2012 at 11:03 PM, Lukáš Czerner lczer...@redhat.com wrote: So I've finally has some time to look at the patch and reproduce the problem. Thanks for noticing the problem

Re: [PATCH v2] ext4: fix hole punch failure when depth is greater than 0

2012-07-09 Thread Ashish Sangwan
Ok, the code is not very clear, but now I can see it. p_block is actually misused here to store the number of indexes in the current node while diving into the tree. Then on the way up, we are checking that to see if the eh_entries changed or not (which is indicating that something has been