Re: [PATCH v2] extcon: ptn5150: Deduplicate parts of dev_err_probe()

2020-08-26 Thread Chanwoo Choi
Hi Andy, On 8/27/20 12:23 AM, Andy Shevchenko wrote: > dev_err_probe() is designed to be used like > > return dev_err_probe(dev, ret, "Error message\n"); > > Hence no need to have a separate return statement. Besides that > dev_err_probe() prints already returned error code, no need to rep

[PATCH v2] extcon: ptn5150: Deduplicate parts of dev_err_probe()

2020-08-26 Thread Andy Shevchenko
dev_err_probe() is designed to be used like return dev_err_probe(dev, ret, "Error message\n"); Hence no need to have a separate return statement. Besides that dev_err_probe() prints already returned error code, no need to repeat that either. Cc: Vijai Kumar K Signed-off-by: Andy Shevche