Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-28 Thread Chao Yu
On 2021/1/29 0:21, Jaegeuk Kim wrote: On 01/20, Chao Yu wrote: On 2021/1/20 3:06, Jaegeuk Kim wrote: On 01/15, Chao Yu wrote: On 2021/1/15 5:53, Jaegeuk Kim wrote: On 12/30, Chao Yu wrote: ThreadA ThreadB - f2fs_ioc_start_atomic_write - write -

Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-28 Thread Jaegeuk Kim
On 01/20, Chao Yu wrote: > On 2021/1/20 3:06, Jaegeuk Kim wrote: > > On 01/15, Chao Yu wrote: > > > On 2021/1/15 5:53, Jaegeuk Kim wrote: > > > > On 12/30, Chao Yu wrote: > > > > > ThreadA ThreadB > > > > > - f2fs_ioc_start_atomic_write > > > > > - write > > >

Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-19 Thread Chao Yu
On 2021/1/20 3:06, Jaegeuk Kim wrote: On 01/15, Chao Yu wrote: On 2021/1/15 5:53, Jaegeuk Kim wrote: On 12/30, Chao Yu wrote: ThreadA ThreadB - f2fs_ioc_start_atomic_write - write - f2fs_ioc_commit_atomic_write - f2fs_commit_inmem_pages -

Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-19 Thread Jaegeuk Kim
On 01/15, Chao Yu wrote: > On 2021/1/15 5:53, Jaegeuk Kim wrote: > > On 12/30, Chao Yu wrote: > > > ThreadA ThreadB > > > - f2fs_ioc_start_atomic_write > > > - write > > > - f2fs_ioc_commit_atomic_write > > > - f2fs_commit_inmem_pages > > > -

Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-15 Thread Chao Yu
On 2021/1/15 5:53, Jaegeuk Kim wrote: On 12/30, Chao Yu wrote: ThreadA ThreadB - f2fs_ioc_start_atomic_write - write - f2fs_ioc_commit_atomic_write - f2fs_commit_inmem_pages - f2fs_drop_inmem_pages - f2fs_drop_inmem_pages - __revoke_inmem_pages

Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-14 Thread Jaegeuk Kim
On 12/30, Chao Yu wrote: > ThreadA ThreadB > - f2fs_ioc_start_atomic_write > - write > - f2fs_ioc_commit_atomic_write > - f2fs_commit_inmem_pages > - f2fs_drop_inmem_pages > - f2fs_drop_inmem_pages > - __revoke_inmem_pages >

Re: [f2fs-dev] [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-12 Thread Chao Yu
On 2021/1/13 6:32, Jaegeuk Kim wrote: On 01/12, Chao Yu wrote: On 2021/1/12 0:32, Jaegeuk Kim wrote: On 01/06, Jaegeuk Kim wrote: On 01/06, Jaegeuk Kim wrote: Hi Chao, With a quick test, this patch causes down_write failure resulting in blocking process. I didn't dig in the bug so, please

Re: [f2fs-dev] [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-12 Thread Jaegeuk Kim
On 01/12, Chao Yu wrote: > On 2021/1/12 0:32, Jaegeuk Kim wrote: > > On 01/06, Jaegeuk Kim wrote: > > > On 01/06, Jaegeuk Kim wrote: > > > > Hi Chao, > > > > > > > > With a quick test, this patch causes down_write failure resulting in > > > > blocking > > > > process. I didn't dig in the bug so,

Re: [f2fs-dev] [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-11 Thread Chao Yu
On 2021/1/12 0:32, Jaegeuk Kim wrote: On 01/06, Jaegeuk Kim wrote: On 01/06, Jaegeuk Kim wrote: Hi Chao, With a quick test, this patch causes down_write failure resulting in blocking process. I didn't dig in the bug so, please check the code again. :P nvm. I can see it works now. Hmm,

Re: [f2fs-dev] [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-11 Thread Jaegeuk Kim
On 01/06, Jaegeuk Kim wrote: > On 01/06, Jaegeuk Kim wrote: > > Hi Chao, > > > > With a quick test, this patch causes down_write failure resulting in > > blocking > > process. I didn't dig in the bug so, please check the code again. :P > > nvm. I can see it works now. Hmm, this gives a huge

Re: [f2fs-dev] [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-06 Thread Jaegeuk Kim
On 01/06, Jaegeuk Kim wrote: > Hi Chao, > > With a quick test, this patch causes down_write failure resulting in blocking > process. I didn't dig in the bug so, please check the code again. :P nvm. I can see it works now. > > On 12/30, Chao Yu wrote: > > ThreadA

Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-06 Thread Jaegeuk Kim
Hi Chao, With a quick test, this patch causes down_write failure resulting in blocking process. I didn't dig in the bug so, please check the code again. :P On 12/30, Chao Yu wrote: > ThreadA ThreadB > - f2fs_ioc_start_atomic_write > - write > -

[PATCH v2] f2fs: fix to keep isolation of atomic write

2020-12-29 Thread Chao Yu
ThreadA ThreadB - f2fs_ioc_start_atomic_write - write - f2fs_ioc_commit_atomic_write - f2fs_commit_inmem_pages - f2fs_drop_inmem_pages - f2fs_drop_inmem_pages - __revoke_inmem_pages - f2fs_vm_page_mkwrite