Re: [f2fs-dev] [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Chao Yu
On 2020/10/31 0:55, Eric Biggers wrote: On Fri, Oct 30, 2020 at 03:26:10PM +0800, Chao Yu wrote: + +struct f2fs_gc_range { + u32 sync; + u64 start; + u64 len; +}; Userspace headers need to use __u32, __u64, etc. instead of u32, u64, etc. Correct. Did you try installing

Re: [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread kernel test robot
Hi Chao, I love your patch! Yet something to improve: [auto build test ERROR on f2fs/dev-test] [also build test ERROR on linus/master v5.10-rc1 next-20201030] [cannot apply to linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [f2fs-dev] [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Eric Biggers
On Fri, Oct 30, 2020 at 03:26:10PM +0800, Chao Yu wrote: > + > +struct f2fs_gc_range { > + u32 sync; > + u64 start; > + u64 len; > +}; Userspace headers need to use __u32, __u64, etc. instead of u32, u64, etc. Did you try installing this header, and including it in a userspace

Re: [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Chao Yu
On 2020-10-30 20:30, Jaegeuk Kim wrote: Hi Chao, Can we make a documentation for this in f2fs.rst? Jaegeuk, Sure, let me work on this. Thanks, Thanks, On 10/30, Chao Yu wrote: Like other filesystem does, we introduce a new file f2fs.h in path of include/uapi/linux/, and move

Re: [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Jaegeuk Kim
Hi Chao, Can we make a documentation for this in f2fs.rst? Thanks, On 10/30, Chao Yu wrote: > Like other filesystem does, we introduce a new file f2fs.h in path of > include/uapi/linux/, and move f2fs-specified ioctl interface definitions > to that file, after then, in order to use those

[PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Chao Yu
Like other filesystem does, we introduce a new file f2fs.h in path of include/uapi/linux/, and move f2fs-specified ioctl interface definitions to that file, after then, in order to use those definitions, userspace developer only need to include the new header file rather than copy & paste