Re: [PATCH v2] fault-inject: support systematic fault injection

2017-05-24 Thread Dmitry Vyukov
Hi, I've made the current interface work with all types of our sandboxes. For setuid the secret souse was prctl(PR_SET_DUMPABLE, 1, 0, 0, 0) to make /proc entries non-root owned. So I am fine with the current version of the code. Andrew, I see that this is already in linux-next. Please proceed w

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-04-09 Thread Akinobu Mita
2017-04-09 2:40 GMT+09:00 Dmitry Vyukov : > On Fri, Apr 7, 2017 at 6:47 PM, Akinobu Mita wrote: >> 2017-04-07 3:33 GMT+09:00 Michal Hocko : >>> [Let's add linux-api - please always cc this list when adding/modifying >>> user visible interfaces] >>> >>> On Tue 28-03-17 15:01:28, Dmitry Vyukov wrote

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-04-08 Thread Dmitry Vyukov
On Fri, Apr 7, 2017 at 6:47 PM, Akinobu Mita wrote: > 2017-04-07 3:33 GMT+09:00 Michal Hocko : >> [Let's add linux-api - please always cc this list when adding/modifying >> user visible interfaces] >> >> On Tue 28-03-17 15:01:28, Dmitry Vyukov wrote: >>> Add /proc/self/task//fail-nth file that all

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-04-07 Thread Akinobu Mita
2017-04-07 3:33 GMT+09:00 Michal Hocko : > [Let's add linux-api - please always cc this list when adding/modifying > user visible interfaces] > > On Tue 28-03-17 15:01:28, Dmitry Vyukov wrote: >> Add /proc/self/task//fail-nth file that allows failing >> 0-th, 1-st, 2-nd and so on calls systematical

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-04-06 Thread Michal Hocko
[Let's add linux-api - please always cc this list when adding/modifying user visible interfaces] On Tue 28-03-17 15:01:28, Dmitry Vyukov wrote: > Add /proc/self/task//fail-nth file that allows failing > 0-th, 1-st, 2-nd and so on calls systematically. > Excerpt from the added documentation: I did

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-04-04 Thread Akinobu Mita
2017-03-28 22:01 GMT+09:00 Dmitry Vyukov : > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 6e8655845830..66001172249b 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -1353,6 +1353,53 @@ static const struct file_operations > proc_fault_inject_operations = { > .write

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-03-30 Thread Andrew Morton
On Tue, 28 Mar 2017 15:01:28 +0200 Dmitry Vyukov wrote: > +static ssize_t proc_fail_nth_write(struct file *file, const char __user *buf, > +size_t count, loff_t *ppos) > +{ > + struct task_struct *task; > + int err, n; > + > + task = get_proc_task(file_

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-03-28 Thread Akinobu Mita
2017-03-28 22:01 GMT+09:00 Dmitry Vyukov : > Add /proc/self/task//fail-nth file that allows failing > 0-th, 1-st, 2-nd and so on calls systematically. > Excerpt from the added documentation: > > === > Write to this file of integer N makes N-th call in the current task fail > (N is 0-based). Read fr

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-03-28 Thread Andrew Morton
On Tue, 28 Mar 2017 15:01:28 +0200 Dmitry Vyukov wrote: > Add /proc/self/task//fail-nth file that allows failing > 0-th, 1-st, 2-nd and so on calls systematically. > Excerpt from the added documentation: > > === > Write to this file of integer N makes N-th call in the current task fail > (N is 0

[PATCH v2] fault-inject: support systematic fault injection

2017-03-28 Thread Dmitry Vyukov
Add /proc/self/task//fail-nth file that allows failing 0-th, 1-st, 2-nd and so on calls systematically. Excerpt from the added documentation: === Write to this file of integer N makes N-th call in the current task fail (N is 0-based). Read from this file returns a single char 'Y' or 'N' that says