Re: [PATCH v2] fb_defio: Remove custom address_space_operations

2021-03-12 Thread Daniel Vetter
On Wed, Mar 10, 2021 at 06:55:30PM +, Matthew Wilcox (Oracle) wrote: > There's no need to give the page an address_space. Leaving the > page->mapping as NULL will cause the VM to handle set_page_dirty() > the same way that it's handled now, and that was the only reason to > set the address_spa

Re: [PATCH v2] fb_defio: Remove custom address_space_operations

2021-03-10 Thread William Kucharski
Looks good; my apologies for missing the leftover declaration of struct page in the same routine which you also found and removed this time around. > On Mar 10, 2021, at 11:55 AM, Matthew Wilcox (Oracle) > wrote: > > There's no need to give the page an address_space. Leaving the > page->mappi

[PATCH v2] fb_defio: Remove custom address_space_operations

2021-03-10 Thread Matthew Wilcox (Oracle)
There's no need to give the page an address_space. Leaving the page->mapping as NULL will cause the VM to handle set_page_dirty() the same way that it's handled now, and that was the only reason to set the address_space in the first place. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Chri