Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-04-11 Thread Michael S. Tsirkin
On Mon, Apr 11, 2016 at 09:13:00AM -0400, Gabriel L. Somlo wrote: > On Tue, Apr 05, 2016 at 11:54:19AM +0300, Michael S. Tsirkin wrote: > > On Thu, Mar 17, 2016 at 09:33:40AM -0400, Gabriel L. Somlo wrote: > > > On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote: > > > > On Tue, Mar

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-04-11 Thread Gabriel L. Somlo
On Tue, Apr 05, 2016 at 11:54:19AM +0300, Michael S. Tsirkin wrote: > On Thu, Mar 17, 2016 at 09:33:40AM -0400, Gabriel L. Somlo wrote: > > On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > > > > Allowing for t

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-04-05 Thread Michael S. Tsirkin
On Thu, Mar 17, 2016 at 09:33:40AM -0400, Gabriel L. Somlo wrote: > On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote: > > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > > > Allowing for the future possibility of implementing AML-based > > > (i.e., firmware-trigge

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-04-03 Thread Michael S. Tsirkin
On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > Allowing for the future possibility of implementing AML-based > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > acquire the global ACPI lock when accessing the device on behalf > of the guest-side sysfs driver, to preve

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-19 Thread Michael S. Tsirkin
On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > Allowing for the future possibility of implementing AML-based > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > acquire the global ACPI lock when accessing the device on behalf > of the guest-side sysfs driver, to preve

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 17:57, Michael S. Tsirkin wrote: > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: >> Allowing for the future possibility of implementing AML-based >> (i.e., firmware-triggered) access to the QEMU fw_cfg device, >> acquire the global ACPI lock when accessing the devic

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-19 Thread Gabriel L. Somlo
On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > > Allowing for the future possibility of implementing AML-based > > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > > acquire the global ACPI lock wh

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-19 Thread Michael S. Tsirkin
On Thu, Mar 17, 2016 at 09:33:40AM -0400, Gabriel L. Somlo wrote: > On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote: > > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > > > Allowing for the future possibility of implementing AML-based > > > (i.e., firmware-trigge

Re: [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-09 Thread Michael S. Tsirkin
On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > Allowing for the future possibility of implementing AML-based > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > acquire the global ACPI lock when accessing the device on behalf > of the guest-side sysfs driver, to preve

[PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-08 Thread Gabriel Somlo
Allowing for the future possibility of implementing AML-based (i.e., firmware-triggered) access to the QEMU fw_cfg device, acquire the global ACPI lock when accessing the device on behalf of the guest-side sysfs driver, to prevent any potential race conditions. Suggested-by: Michael S. Tsirkin Si