Re: [PATCH v2] fix printk output

2014-04-23 Thread Lucas De Marchi
On Wed, Apr 23, 2014 at 2:14 AM, Rusty Russell wrote: > Sergei Ianovich writes: >> On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: >>> BTW, did you actually hit this? >> >> # modprobe usb_storage >> [ 600.807274] usbcore: registered new interface driver usb-storage >> # modprobe -r

Re: [PATCH v2] fix printk output

2014-04-23 Thread Lucas De Marchi
On Wed, Apr 23, 2014 at 2:14 AM, Rusty Russell ru...@rustcorp.com.au wrote: Sergei Ianovich ynv...@gmail.com writes: On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: BTW, did you actually hit this? # modprobe usb_storage [ 600.807274] usbcore: registered new interface driver

Re: [PATCH v2] fix printk output

2014-04-22 Thread Rusty Russell
Sergei Ianovich writes: > On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: >> BTW, did you actually hit this? > > # modprobe usb_storage > [ 600.807274] usbcore: registered new interface driver usb-storage > # modprobe -r usb_storage > [ 604.216318] waiting module removal not supported:

Re: [PATCH v2] fix printk output

2014-04-22 Thread Rusty Russell
Sergei Ianovich ynv...@gmail.com writes: On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: BTW, did you actually hit this? # modprobe usb_storage [ 600.807274] usbcore: registered new interface driver usb-storage # modprobe -r usb_storage [ 604.216318] waiting module removal not

Re: [PATCH v2] fix printk output

2013-12-09 Thread Sergei Ianovich
On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: > Sergei Ianovich writes: > Hmm, the copy here is gratuitous. Using current->comm is safe, just > possibly ambigious if someone is changing the task name at the same time. > > And we really want this one line anyway: > >

Re: [PATCH v2] fix printk output

2013-12-09 Thread Rusty Russell
Sergei Ianovich writes: > Signed-off-by: Sergei Ianovich > CC: Hannes Frederic Sowa > --- > Changes v1..v2 > * 1-for-1 match between source and output lines > * clarify warning > * print tool name to avoid confusion with what to upgrade Hmm, the copy here is gratuitous. Using

Re: [PATCH v2] fix printk output

2013-12-09 Thread Rusty Russell
Sergei Ianovich ynv...@gmail.com writes: Signed-off-by: Sergei Ianovich ynv...@gmail.com CC: Hannes Frederic Sowa han...@stressinduktion.org --- Changes v1..v2 * 1-for-1 match between source and output lines * clarify warning * print tool name to avoid confusion with what to upgrade

Re: [PATCH v2] fix printk output

2013-12-09 Thread Sergei Ianovich
On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: Sergei Ianovich ynv...@gmail.com writes: Hmm, the copy here is gratuitous. Using current-comm is safe, just possibly ambigious if someone is changing the task name at the same time. And we really want this one line anyway:

[PATCH v2] fix printk output

2013-11-30 Thread Sergei Ianovich
Signed-off-by: Sergei Ianovich CC: Hannes Frederic Sowa --- Changes v1..v2 * 1-for-1 match between source and output lines * clarify warning * print tool name to avoid confusion with what to upgrade kernel/module.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v2] fix printk output

2013-11-30 Thread Sergei Ianovich
Signed-off-by: Sergei Ianovich ynv...@gmail.com CC: Hannes Frederic Sowa han...@stressinduktion.org --- Changes v1..v2 * 1-for-1 match between source and output lines * clarify warning * print tool name to avoid confusion with what to upgrade kernel/module.c | 4 +++- 1 file changed, 3