Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-15 Thread Thavatchai Makphaibulchoke
On 04/15/2014 11:25 AM, Jan Kara wrote: > I have checked the source and I didn't find many places where i_mutex was > not held. But maybe I'm wrong. That's why I wanted to see the patch where > you are using i_mutex instead of hashed mutexes and which didn't perform > good enough. > I've attach

Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-15 Thread Jan Kara
On Tue 15-04-14 10:27:46, Thavatchai Makphaibulchoke wrote: > On 04/14/2014 11:40 AM, Jan Kara wrote: > > Thanks for trying that out! Can you please send me a patch you have been > > testing? Because it doesn't quite make sense to me why using i_mutex should > > be worse than using hashed locks..

Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-15 Thread Thavatchai Makphaibulchoke
On 04/14/2014 11:40 AM, Jan Kara wrote: > Thanks for trying that out! Can you please send me a patch you have been > testing? Because it doesn't quite make sense to me why using i_mutex should > be worse than using hashed locks... > Thanks again for the comments. Since i_mutex is also used for

Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-14 Thread Jan Kara
On Mon 14-04-14 10:56:58, Thavatchai Makphaibulchoke wrote: > On 04/02/2014 11:41 AM, Jan Kara wrote: > > Thanks for the patches and measurements! So I agree we contend a lot on > > orphan list changes in ext4. But what you do seems to be unnecessarily > > complicated and somewhat hiding the real

Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-14 Thread Thavatchai Makphaibulchoke
On 04/02/2014 11:41 AM, Jan Kara wrote: > Thanks for the patches and measurements! So I agree we contend a lot on > orphan list changes in ext4. But what you do seems to be unnecessarily > complicated and somewhat hiding the real substance of the patch. If I > understand your patch correctly, all

Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-02 Thread Thavatchai Makphaibulchoke
On 04/02/2014 11:41 AM, Jan Kara wrote: > Thanks for the patches and measurements! So I agree we contend a lot on > orphan list changes in ext4. But what you do seems to be unnecessarily > complicated and somewhat hiding the real substance of the patch. If I > understand your patch correctly, all

Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-02 Thread Jan Kara
On Wed 02-04-14 10:29:08, T Makphaibulchoke wrote: > Instead of allowing only a single atomic update (both in memory and on disk > orphan lists) of an ext4's orphan list via the s_orphan_lock mutex, this patch > allows multiple updates of the orphan list, while still maintaing the > integrity of bo

[PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

2014-04-02 Thread T Makphaibulchoke
Instead of allowing only a single atomic update (both in memory and on disk orphan lists) of an ext4's orphan list via the s_orphan_lock mutex, this patch allows multiple updates of the orphan list, while still maintaing the integrity of both the in memory and on disk orphan lists of each update.