Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread Jeff Layton
On Wed, 2016-11-09 at 15:23 -0500, J. Bruce Fields wrote: On Wed, Nov 09, 2016 at 02:47:24PM -0500, J. Bruce Fields wrote: For now I wish we could just like to continue assuming the workqueue processes only one item at a time. Do we have that now, or do we need to switch to (looking at workqueue.

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread J. Bruce Fields
On Wed, Nov 09, 2016 at 02:47:24PM -0500, J. Bruce Fields wrote: > For now I wish we could just like to continue assuming the workqueue > processes only one item at a time. Do we have that now, or do we need > to switch to (looking at workqueue.h...) alloc_ordered workqueue()? Oh, wait, I missed

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread J. Bruce Fields
On Wed, Nov 09, 2016 at 12:33:35PM -0500, Jeff Layton wrote: > On Wed, 2016-11-09 at 11:27 -0500, J. Bruce Fields wrote: > > On Wed, Nov 09, 2016 at 08:18:08AM -0500, Jeff Layton wrote: > > > > > > On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote: > > > > > > > > On Tue, Nov 08, 2016 at 0

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread Jeff Layton
On Wed, 2016-11-09 at 11:27 -0500, J. Bruce Fields wrote: > On Wed, Nov 09, 2016 at 08:18:08AM -0500, Jeff Layton wrote: > > > > On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote: > > > > > > On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote: > > > > > > > > > > > > Hello, Bruce.

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread J. Bruce Fields
On Wed, Nov 09, 2016 at 08:18:08AM -0500, Jeff Layton wrote: > On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote: > > On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote: > > > > > > Hello, Bruce. > > > > > > On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote: > > > > >

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread Jeff Layton
On Wed, 2016-11-09 at 15:08 +, Trond Myklebust wrote: > On Wed, 2016-11-09 at 08:18 -0500, Jeff Layton wrote: > > > > On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote: > > > > > > > > > On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote: > > > > > > > > > > > > > > > > Hell

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread Trond Myklebust
On Wed, 2016-11-09 at 08:18 -0500, Jeff Layton wrote: > On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote: > > > > On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote: > > > > > > > > > Hello, Bruce. > > > > > > On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote: > > >

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-09 Thread Jeff Layton
On Tue, 2016-11-08 at 20:27 -0500, J. Bruce Fields wrote: > On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote: > > > > Hello, Bruce. > > > > On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote: > > > > > > Apologies, just cleaning out old mail and finding some I should have >

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-08 Thread J. Bruce Fields
On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote: > Hello, Bruce. > > On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote: > > Apologies, just cleaning out old mail and finding some I should have > > responded to long ago: > > > > On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bha

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-08 Thread Tejun Heo
Hello, Bruce. On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote: > Apologies, just cleaning out old mail and finding some I should have > responded to long ago: > > On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bhaktipriya Shridhar wrote: > > The workqueue "callback_wq" queues a single

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-11-08 Thread J. Bruce Fields
Apologies, just cleaning out old mail and finding some I should have responded to long ago: On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bhaktipriya Shridhar wrote: > The workqueue "callback_wq" queues a single work item &cb->cb_work per > nfsd4_callback instance and thus, it doesn't require executio

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-08-31 Thread Jeff Layton
On Wed, 2016-08-31 at 10:39 -0400, Tejun Heo wrote: > Hello, Jeff. > > On Tue, Aug 30, 2016 at 05:07:23PM -0400, Jeff Layton wrote: > > > > Hah! I have almost exactly the same patch in my tree. I've only not > > sent it because I haven't had the chance to test it well. > > > > The only differenc

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-08-31 Thread Tejun Heo
Hello, Jeff. On Tue, Aug 30, 2016 at 05:07:23PM -0400, Jeff Layton wrote: > Hah! I have almost exactly the same patch in my tree. I've only not > sent it because I haven't had the chance to test it well. > > The only difference in mine is that it passes in WQ_UNBOUND. ISTM that > we don't really

Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-08-30 Thread Jeff Layton
On Wed, 2016-08-31 at 02:23 +0530, Bhaktipriya Shridhar wrote: > The workqueue "callback_wq" queues a single work item &cb->cb_work > per > nfsd4_callback instance and thus, it doesn't require execution > ordering. > Hence, alloc_workqueue has been used to replace the > deprecated create_singlethre

[PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue

2016-08-30 Thread Bhaktipriya Shridhar
The workqueue "callback_wq" queues a single work item &cb->cb_work per nfsd4_callback instance and thus, it doesn't require execution ordering. Hence, alloc_workqueue has been used to replace the deprecated create_singlethread_workqueue instance. The WQ_MEM_RECLAIM flag has not been set since this