Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-08-02 Thread J. Bruce Fields
On Thu, Aug 02, 2018 at 01:00:26PM +, Nixiaoming wrote: > On Wednesday, August 01, 2018 11:18 PM , J. Bruce Fields wrote: > >On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote: > >> READ_BUF(8); > >> dummy = be32_to_cpup(p++); > >> dummy = be32_to_cpup(p++); > >> ... > >> READ_BUF(4)

RE: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-08-02 Thread Nixiaoming
On Wednesday, August 01, 2018 11:18 PM , J. Bruce Fields wrote: >On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote: >> READ_BUF(8); >> dummy = be32_to_cpup(p++); >> dummy = be32_to_cpup(p++); >> ... >> READ_BUF(4); >> dummy = be32_to_cpup(p++); >> >> Assigning value to "dummy" here, bu

Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-08-01 Thread J. Bruce Fields
On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote: > READ_BUF(8); > dummy = be32_to_cpup(p++); > dummy = be32_to_cpup(p++); > ... > READ_BUF(4); > dummy = be32_to_cpup(p++); > > Assigning value to "dummy" here, but that stored value > is overwritten before it can be used. > At the same ti

[PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-07-22 Thread nixiaoming
READ_BUF(8); dummy = be32_to_cpup(p++); dummy = be32_to_cpup(p++); ... READ_BUF(4); dummy = be32_to_cpup(p++); Assigning value to "dummy" here, but that stored value is overwritten before it can be used. At the same time READ_BUF() will re-update the pointer p. delete invalid assignment statement