Re: [PATCH v2] fs: fs_parser: avoid NULL param->string to kstrtouint

2019-08-21 Thread Al Viro
On Wed, Aug 21, 2019 at 09:22:49PM -0700, Eric Biggers wrote: > > > diff --git a/fs/fs_parser.c b/fs/fs_parser.c > > > index 83b66c9e9a24..7498a44f18c0 100644 > > > --- a/fs/fs_parser.c > > > +++ b/fs/fs_parser.c > > > @@ -206,6 +206,9 @@ int fs_parse(struct fs_context *fc, > > > case

Re: [PATCH v2] fs: fs_parser: avoid NULL param->string to kstrtouint

2019-08-21 Thread Eric Biggers
[trimmed Cc list a bit] On Thu, Aug 15, 2019 at 07:46:56PM -0700, Eric Biggers wrote: > On Sat, Jul 20, 2019 at 07:29:49AM +0800, Yin Fengwei wrote: > > syzbot reported general protection fault in kstrtouint: > > https://lkml.org/lkml/2019/7/18/328 > > > > From the log, if the mount option is

Re: [PATCH v2] fs: fs_parser: avoid NULL param->string to kstrtouint

2019-08-15 Thread Eric Biggers
On Sat, Jul 20, 2019 at 07:29:49AM +0800, Yin Fengwei wrote: > syzbot reported general protection fault in kstrtouint: > https://lkml.org/lkml/2019/7/18/328 > > From the log, if the mount option is something like: >fd, > > The default parameter (which has NULL

[PATCH v2] fs: fs_parser: avoid NULL param->string to kstrtouint

2019-07-19 Thread Yin Fengwei
syzbot reported general protection fault in kstrtouint: https://lkml.org/lkml/2019/7/18/328 >From the log, if the mount option is something like: fd, The default parameter (which has NULL param->string) will be passed to vfs_parse_fs_param. Finally, this NULL param->string