Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-19 Thread Benjamin Herrenschmidt
On Sat, 2019-10-19 at 01:31 +, Vijay Khemka wrote: > Thanks Ben, > I will try to add some trace and test whatever possible and test it. > As we > don't have tcpdump into our image and I have limited understanding of > networking stack so if you get some time to verify ipv6, it will be > really

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-18 Thread Vijay Khemka
On 10/18/19, 5:03 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-18 at 22:50 +, Vijay Khemka wrote: > I don't have much understanding of IP Stack but I went through code details and > you are right and found that it should fallback to SW calculation for IPV6 but it

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-18 Thread Benjamin Herrenschmidt
On Fri, 2019-10-18 at 22:50 +, Vijay Khemka wrote: > I don't have much understanding of IP Stack but I went through code details > and > you are right and found that it should fallback to SW calculation for IPV6 > but it doesn't > happen because ftgmac100_hard_start_xmit checks for

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-18 Thread Vijay Khemka
On 10/17/19, 5:33 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-18 at 00:06 +, Vijay Khemka wrote: > > > This is not a matter of unsupported csum, it is broken hw csum. > > That's why we disable hw checksum. My guess is once we disable > > Hw

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Benjamin Herrenschmidt
On Fri, 2019-10-18 at 00:06 +, Vijay Khemka wrote: > > > This is not a matter of unsupported csum, it is broken hw csum. > > That's why we disable hw checksum. My guess is once we disable > > Hw checksum, it will use sw checksum. So I am just disabling hw > > Checksum. >

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Vijay Khemka
On 10/17/19, 4:15 PM, "Benjamin Herrenschmidt" wrote: On Thu, 2019-10-17 at 22:01 +, Vijay Khemka wrote: > > On 10/16/19, 6:29 PM, "Benjamin Herrenschmidt" wrote: > > On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: > > HW checksum generation is

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Benjamin Herrenschmidt
On Fri, 2019-10-18 at 10:14 +1100, Benjamin Herrenschmidt wrote: > > I don't understand what you are saying. You reported a problem with > IPV6 checksums generation. The HW doesn't support it. What's "not a > matter of unsupported csum" ? > > Your patch uses a *deprecated* bit to tell the

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Benjamin Herrenschmidt
On Thu, 2019-10-17 at 22:01 +, Vijay Khemka wrote: > > On 10/16/19, 6:29 PM, "Benjamin Herrenschmidt" > wrote: > > On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: > > HW checksum generation is not working for AST2500, specially with > > IPV6 > > over NCSI. All TCP

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Vijay Khemka
On 10/16/19, 6:29 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with > IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-16 Thread Benjamin Herrenschmidt
On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with > IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfectly fine with IPV6. As it works for IPV4 so enabled > hw checksum back for IPV4.

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Jakub Kicinski
On Thu, 10 Oct 2019 19:20:47 +, Vijay Khemka wrote: > Resending this patch again. Perhaps I'm missing context but what's the intention here? In case this is resubmitting the patch for inclusion in the upstream kernel you need to send it out properly with git send-email or such.. > On

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Vijay Khemka
Resending this patch again. On 9/11/19, 1:05 PM, "Vijay Khemka" wrote: HW checksum generation is not working for AST2500, specially with IPV6 over NCSI. All TCP packets with IPv6 get dropped. By disabling this it works perfectly fine with IPV6. As it works for IPV4 so enabled

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-09-24 Thread Vijay Khemka
Florian/Joel, Can you please look into below patch and let me know who can apply this. Regards -Vijay On 9/17/19, 12:34 PM, "Vijay Khemka" wrote: Please review below patch and provide your valuable feedback. Regards -Vijay On 9/11/19, 1:05 PM, "Vijay Khemka" wrote:

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-09-17 Thread Vijay Khemka
Please review below patch and provide your valuable feedback. Regards -Vijay On 9/11/19, 1:05 PM, "Vijay Khemka" wrote: HW checksum generation is not working for AST2500, specially with IPV6 over NCSI. All TCP packets with IPv6 get dropped. By disabling this it works perfectly