Re: [PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-14 Thread Tony Prisk
On Tue, 2013-01-15 at 07:37 +1300, Tony Prisk wrote: > This driver is missing a .remove callback, and the fail path on > probe is incomplete. > > If an error occurs in vt8500_add_chips, gpio_base is not unmapped. > The driver is also ignoring the return value from this function so > if a chip fail

[PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-14 Thread Tony Prisk
This driver is missing a .remove callback, and the fail path on probe is incomplete. If an error occurs in vt8500_add_chips, gpio_base is not unmapped. The driver is also ignoring the return value from this function so if a chip fails to register it completes as successful. Replaced pr_err with d

Re: [PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-14 Thread Grant Likely
On Fri, 11 Jan 2013 08:09:46 +1300, Tony Prisk wrote: > This driver is missing a .remove callback, and the fail path on > probe is incomplete. > > If an error occurs in vt8500_add_chips, gpio_base is not unmapped. > The driver is also ignoring the return value from this function so > if a chip fa

[PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-10 Thread Tony Prisk
This driver is missing a .remove callback, and the fail path on probe is incomplete. If an error occurs in vt8500_add_chips, gpio_base is not unmapped. The driver is also ignoring the return value from this function so if a chip fails to register it completes as successful. Replaced pr_err with d