Re: [PATCH v2] gpiolib: cdev: document that line eflags are shared

2020-10-26 Thread Bartosz Golaszewski
On Wed, Oct 14, 2020 at 8:29 AM Kent Gibson wrote: > > The line.eflags field is shared so document this fact and highlight it > throughout using READ_ONCE() and WRITE_ONCE() accessors. > > Also use a local copy of the eflags in edge_irq_thread() to ensure > consistent control flow even if eflags c

Re: [PATCH v2] gpiolib: cdev: document that line eflags are shared

2020-10-16 Thread Kent Gibson
On Fri, Oct 16, 2020 at 05:24:14PM +0300, Andy Shevchenko wrote: > On Wed, Oct 14, 2020 at 12:21 PM Kent Gibson wrote: > > > > The line.eflags field is shared so document this fact and highlight it > > throughout using READ_ONCE() and WRITE_ONCE() accessors. > > > > Also use a local copy of the ef

Re: [PATCH v2] gpiolib: cdev: document that line eflags are shared

2020-10-16 Thread Andy Shevchenko
On Wed, Oct 14, 2020 at 12:21 PM Kent Gibson wrote: > > The line.eflags field is shared so document this fact and highlight it > throughout using READ_ONCE() and WRITE_ONCE() accessors. > > Also use a local copy of the eflags in edge_irq_thread() to ensure > consistent control flow even if eflags

[PATCH v2] gpiolib: cdev: document that line eflags are shared

2020-10-14 Thread Kent Gibson
The line.eflags field is shared so document this fact and highlight it throughout using READ_ONCE() and WRITE_ONCE() accessors. Also use a local copy of the eflags in edge_irq_thread() to ensure consistent control flow even if eflags changes. This is only a defensive measure as edge_irq_thread()