Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-22 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:30 PM, Colin Cross wrote: > On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton > wrote: >> On Mon, 14 Jan 2013 16:19:23 -0800 >> Colin Cross wrote: >> >>> >> +static void watchdog_check_hardlockup_other_cpu(void) >>> >> +{ >>> >> + unsigned int next_cpu; >>> >> + >>>

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-22 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:30 PM, Colin Cross ccr...@android.com wrote: On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 14 Jan 2013 16:19:23 -0800 Colin Cross ccr...@android.com wrote: +static void watchdog_check_hardlockup_other_cpu(void) +{ +

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-15 Thread Paul E. McKenney
On Tue, Jan 15, 2013 at 01:13:10AM +0100, Frederic Weisbecker wrote: > 2013/1/11 Colin Cross : > > Emulate NMIs on systems where they are not available by using timer > > interrupts on other cpus. Each cpu will use its softlockup hrtimer > > to check that the next cpu is processing hrtimer

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-15 Thread Paul E. McKenney
On Tue, Jan 15, 2013 at 01:13:10AM +0100, Frederic Weisbecker wrote: 2013/1/11 Colin Cross ccr...@android.com: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu is processing

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 6:48 PM, Frederic Weisbecker wrote: > 2013/1/15 Colin Cross : >> On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker >> wrote: >>> 2013/1/15 Colin Cross : On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker wrote: > I believe this is pretty much what

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Frederic Weisbecker
2013/1/15 Colin Cross : > On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker > wrote: >> 2013/1/15 Colin Cross : >>> On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker >>> wrote: I believe this is pretty much what the RCU stall detector does already: checks for other CPUs being

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker wrote: > 2013/1/15 Colin Cross : >> On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker >> wrote: >>> I believe this is pretty much what the RCU stall detector does >>> already: checks for other CPUs being responsive. The only difference >>>

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:19 PM, Colin Cross wrote: > On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton > wrote: >> On Fri, 11 Jan 2013 13:51:48 -0800 >> Colin Cross wrote: >> >>> Emulate NMIs on systems where they are not available by using timer >>> interrupts on other cpus. Each cpu will use

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton wrote: > On Mon, 14 Jan 2013 16:19:23 -0800 > Colin Cross wrote: > >> >> +static void watchdog_check_hardlockup_other_cpu(void) >> >> +{ >> >> + unsigned int next_cpu; >> >> + >> >> + /* >> >> + * Test for hardlockups every 3 samples.

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Frederic Weisbecker
2013/1/15 Colin Cross : > On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker > wrote: >> I believe this is pretty much what the RCU stall detector does >> already: checks for other CPUs being responsive. The only difference >> is on how it checks that. For RCU it's about checking for CPUs >>

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Andrew Morton
On Mon, 14 Jan 2013 16:19:23 -0800 Colin Cross wrote: > >> +static void watchdog_check_hardlockup_other_cpu(void) > >> +{ > >> + unsigned int next_cpu; > >> + > >> + /* > >> + * Test for hardlockups every 3 samples. The sample period is > >> + * watchdog_thresh * 2 / 5, so 3

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker wrote: > 2013/1/11 Colin Cross : >> Emulate NMIs on systems where they are not available by using timer >> interrupts on other cpus. Each cpu will use its softlockup hrtimer >> to check that the next cpu is processing hrtimer interrupts by >>

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton wrote: > On Fri, 11 Jan 2013 13:51:48 -0800 > Colin Cross wrote: > >> Emulate NMIs on systems where they are not available by using timer >> interrupts on other cpus. Each cpu will use its softlockup hrtimer >> to check that the next cpu is

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Frederic Weisbecker
2013/1/11 Colin Cross : > Emulate NMIs on systems where they are not available by using timer > interrupts on other cpus. Each cpu will use its softlockup hrtimer > to check that the next cpu is processing hrtimer interrupts by > verifying that a counter is increasing. > > This patch is useful on

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Andrew Morton
On Fri, 11 Jan 2013 13:51:48 -0800 Colin Cross wrote: > Emulate NMIs on systems where they are not available by using timer > interrupts on other cpus. Each cpu will use its softlockup hrtimer > to check that the next cpu is processing hrtimer interrupts by > verifying that a counter is

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Andrew Morton
On Fri, 11 Jan 2013 13:51:48 -0800 Colin Cross ccr...@android.com wrote: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu is processing hrtimer interrupts by verifying that a

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Frederic Weisbecker
2013/1/11 Colin Cross ccr...@android.com: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu is processing hrtimer interrupts by verifying that a counter is increasing. This patch

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 11 Jan 2013 13:51:48 -0800 Colin Cross ccr...@android.com wrote: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/11 Colin Cross ccr...@android.com: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu is

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Andrew Morton
On Mon, 14 Jan 2013 16:19:23 -0800 Colin Cross ccr...@android.com wrote: +static void watchdog_check_hardlockup_other_cpu(void) +{ + unsigned int next_cpu; + + /* + * Test for hardlockups every 3 samples. The sample period is + * watchdog_thresh * 2 / 5, so 3

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Frederic Weisbecker
2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker fweis...@gmail.com wrote: I believe this is pretty much what the RCU stall detector does already: checks for other CPUs being responsive. The only difference is on how it checks that. For RCU it's

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 14 Jan 2013 16:19:23 -0800 Colin Cross ccr...@android.com wrote: +static void watchdog_check_hardlockup_other_cpu(void) +{ + unsigned int next_cpu; + + /* + * Test for hardlockups

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:19 PM, Colin Cross ccr...@android.com wrote: On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 11 Jan 2013 13:51:48 -0800 Colin Cross ccr...@android.com wrote: Emulate NMIs on systems where they are not available by using timer

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker fweis...@gmail.com wrote: I believe this is pretty much what the RCU stall detector does already: checks for other

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Frederic Weisbecker
2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker fweis...@gmail.com wrote: I believe this is pretty much what the RCU stall

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 6:48 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:13 PM, Frederic

[PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-11 Thread Colin Cross
Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu is processing hrtimer interrupts by verifying that a counter is increasing. This patch is useful on systems where the hardlockup

[PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-11 Thread Colin Cross
Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu is processing hrtimer interrupts by verifying that a counter is increasing. This patch is useful on systems where the hardlockup