Re: [PATCH v2] hv_netvsc: Add validation for untrusted Hyper-V values

2020-09-11 Thread Andrea Parri
> > @@ -740,12 +755,45 @@ static void netvsc_send_completion(struct > > net_device *ndev, > >int budget) > > { > > const struct nvsp_message *nvsp_packet = hv_pkt_data(desc); > > + u32 msglen = hv_pkt_datalen(desc); > > + > > + /* Ensure packet is big

[PATCH v2] hv_netvsc: Add validation for untrusted Hyper-V values

2020-09-10 Thread Andrea Parri (Microsoft)
From: Andres Beltran For additional robustness in the face of Hyper-V errors or malicious behavior, validate all values that originate from packets that Hyper-V has sent to the guest in the host-to-guest ring buffer. Ensure that invalid values cannot cause indexing off the end of an array, or

RE: [PATCH v2] hv_netvsc: Add validation for untrusted Hyper-V values

2020-09-10 Thread Haiyang Zhang
chael > Kelley ; Saruhan Karademir > ; Juan Vazquez ; Andrea > Parri ; David S. Miller ; > Jakub Kicinski ; net...@vger.kernel.org > Subject: [PATCH v2] hv_netvsc: Add validation for untrusted Hyper-V values > > From: Andres Beltran > > For additional robustness in