Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-24 Thread Sedat Dilek
> Wolfram Sang hat am 24. August 2018 um 17:01 geschrieben: > > > On Fri, Aug 24, 2018 at 04:19:53PM +0200, Sedat Dilek wrote: > > > Wolfram Sang hat am 24. August 2018 um 16:07 > > > geschrieben: > > > > > > > > > > > > > will my patch go to [1]? > > > > > > It won't be needed anymore, th

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-24 Thread Wolfram Sang
On Fri, Aug 24, 2018 at 04:19:53PM +0200, Sedat Dilek wrote: > > Wolfram Sang hat am 24. August 2018 um 16:07 > > geschrieben: > > > > > > > > > will my patch go to [1]? > > > > It won't be needed anymore, the __deprecated function will go away until > > next week. > > > > The relict in driv

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-24 Thread Sedat Dilek
> Wolfram Sang hat am 24. August 2018 um 16:07 geschrieben: > > > > > will my patch go to [1]? > > It won't be needed anymore, the __deprecated function will go away until > next week. > The relict in drivers/i2/Makefile should go away, too. - sed@ - [1] https://git.kernel.org/pub/scm/linu

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-24 Thread Wolfram Sang
> will my patch go to [1]? It won't be needed anymore, the __deprecated function will go away until next week. signature.asc Description: PGP signature

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-24 Thread Sedat Dilek
Hi Wolfram, will my patch go to [1]? Thank you, too. Regards, - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next > Wolfram Sang hat am 24. August 2018 um 15:01 geschrieben: > > > Sedat, > > > This can be dropped with commit 771c035372a036f83353

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-24 Thread Wolfram Sang
Sedat, > This can be dropped with commit 771c035372a036f83353eef46dbb829780330234 > ("deprecate the '__deprecated' attribute warnings entirely and for good") > now in upstream. The pull request removing attach_adapter() is on the way now. Thanks for triggering all this! Happy hacking, Wolfra

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-20 Thread Wolfram Sang
Linus, > Wolfram, should I just take that patch as-is and get rid of the > deprecated atach_adapter thing, or will you send me a pull request? I'll send you a pull request. Thanks, Wolfram signature.asc Description: PGP signature

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-20 Thread Linus Torvalds
On Mon, Aug 20, 2018 at 1:06 AM Wolfram Sang wrote: > > [1] http://patchwork.ozlabs.org/patch/461759/ Let's just apply this. If it breaks something and somebody notices, we'll at least have found a tester. And if it doesn't break anything, or if nobody ever notices the breakage, then we will ha

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-20 Thread Benjamin Herrenschmidt
On Mon, 2018-08-20 at 10:06 +0200, Wolfram Sang wrote: > > > Some people still use those old machines, I'll give a try at fixing the > > driver. > > I did this here a while ago [1] ("macintosh: therm_windtunnel: drop > using attach adapter")... > > > Paul: Do you still have one of these machines

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-20 Thread Wolfram Sang
On Mon, Aug 20, 2018 at 12:12:47PM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2018-08-19 at 09:46 -0700, Linus Torvalds wrote: > > On Sun, Aug 19, 2018 at 6:51 AM Sedat Dilek wrote: > > > > > > This can be dropped with commit 771c035372a036f83353eef46dbb829780330234 > > > ("deprecate the '__d

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-19 Thread Benjamin Herrenschmidt
On Sun, 2018-08-19 at 09:46 -0700, Linus Torvalds wrote: > On Sun, Aug 19, 2018 at 6:51 AM Sedat Dilek wrote: > > > > This can be dropped with commit 771c035372a036f83353eef46dbb829780330234 > > ("deprecate the '__deprecated' attribute warnings entirely and for good") > > now in upstream. > > Co

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-19 Thread Linus Torvalds
On Sun, Aug 19, 2018 at 6:51 AM Sedat Dilek wrote: > > This can be dropped with commit 771c035372a036f83353eef46dbb829780330234 > ("deprecate the '__deprecated' attribute warnings entirely and for good") > now in upstream. Could we please just remove the __deprecated use in i2c entirely? As fat

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-19 Thread kbuild test robot
Hi Sedat, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on v4.18 next-20180817] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/

[PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-19 Thread Sedat Dilek
This can be dropped with commit 771c035372a036f83353eef46dbb829780330234 ("deprecate the '__deprecated' attribute warnings entirely and for good") now in upstream. Please, use the kbuild infrastruture to disable compiler warnings. This should be... CFLAGS_i2c-core-base.o := $(call cc-disable-warn