Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-29 Thread Joel Stanley
On Fri, Oct 27, 2017 at 7:23 AM, Wolfram Sang wrote: >> > + bus->rst = devm_reset_control_get_optional_shared(>dev, >> > NULL); >> >> This could return error values in case of broken device trees, so you >> may want to check IS_ERR(bus->rst) and handle the error here.

Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-29 Thread Joel Stanley
On Fri, Oct 27, 2017 at 7:23 AM, Wolfram Sang wrote: >> > + bus->rst = devm_reset_control_get_optional_shared(>dev, >> > NULL); >> >> This could return error values in case of broken device trees, so you >> may want to check IS_ERR(bus->rst) and handle the error here. >From my

Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-26 Thread Wolfram Sang
> > + bus->rst = devm_reset_control_get_optional_shared(>dev, NULL); > > This could return error values in case of broken device trees, so you > may want to check IS_ERR(bus->rst) and handle the error here. > > > + reset_control_deassert(bus->rst); > > Otherwise this will dump a

Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-26 Thread Wolfram Sang
> > + bus->rst = devm_reset_control_get_optional_shared(>dev, NULL); > > This could return error values in case of broken device trees, so you > may want to check IS_ERR(bus->rst) and handle the error here. > > > + reset_control_deassert(bus->rst); > > Otherwise this will dump a

Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-18 Thread Philipp Zabel
On Wed, Oct 18, 2017 at 4:29 PM, Joel Stanley wrote: > In order to use i2c from a cold boot, the i2c peripheral must be taken > out of reset. We request a shared reset controller each time a bus > driver is loaded, as the reset is shared between the 14 i2c buses. > > On remove the

Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-18 Thread Philipp Zabel
On Wed, Oct 18, 2017 at 4:29 PM, Joel Stanley wrote: > In order to use i2c from a cold boot, the i2c peripheral must be taken > out of reset. We request a shared reset controller each time a bus > driver is loaded, as the reset is shared between the 14 i2c buses. > > On remove the reset is

Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-18 Thread Brendan Higgins
On Wed, Oct 18, 2017 at 7:29 AM, Joel Stanley wrote: > In order to use i2c from a cold boot, the i2c peripheral must be taken > out of reset. We request a shared reset controller each time a bus > driver is loaded, as the reset is shared between the 14 i2c buses. > > On remove the

Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-18 Thread Brendan Higgins
On Wed, Oct 18, 2017 at 7:29 AM, Joel Stanley wrote: > In order to use i2c from a cold boot, the i2c peripheral must be taken > out of reset. We request a shared reset controller each time a bus > driver is loaded, as the reset is shared between the 14 i2c buses. > > On remove the reset is

[PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-18 Thread Joel Stanley
In order to use i2c from a cold boot, the i2c peripheral must be taken out of reset. We request a shared reset controller each time a bus driver is loaded, as the reset is shared between the 14 i2c buses. On remove the reset is asserted, which only touches the hardware once the last i2c bus is

[PATCH v2] i2c: aspeed: Deassert reset in probe

2017-10-18 Thread Joel Stanley
In order to use i2c from a cold boot, the i2c peripheral must be taken out of reset. We request a shared reset controller each time a bus driver is loaded, as the reset is shared between the 14 i2c buses. On remove the reset is asserted, which only touches the hardware once the last i2c bus is