Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2019-05-28 Thread Jean Delvare
On Tue, 28 May 2019 11:54:02 +0200, Pali Rohár wrote: > On Tuesday 28 May 2019 11:50:15 Jean Delvare wrote: > > OK, thanks for the explanation. But assuming that we now instantiate > > the lis2lv02d device from i2c-i801 for exactly all the same machines, > > can't we just *enable* the freefall

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2019-05-28 Thread Pali Rohár
On Tuesday 28 May 2019 11:50:15 Jean Delvare wrote: > On Tue, 2019-05-28 at 11:41 +0200, Pali Rohár wrote: > > This is not a problem. lis3lv02d provides two things: > > > > 1) 3 axes accelerometer > > 2) optional interrupt and signal it to userspace via misc device > > > > dell-smo8800 does not

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2019-05-28 Thread Jean Delvare
On Tue, 2019-05-28 at 11:41 +0200, Pali Rohár wrote: > This is not a problem. lis3lv02d provides two things: > > 1) 3 axes accelerometer > 2) optional interrupt and signal it to userspace via misc device > > dell-smo8800 does not call any parts of lis2lv02d module. It just > provides for

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2019-05-28 Thread Pali Rohár
Hi! Thank you finally for response! On Tuesday 28 May 2019 11:19:53 Jean Delvare wrote: > On Mon, 26 Feb 2018 21:32:55 +0100, Wolfram Sang wrote: > > > I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > > > Therefore instructing future contributors would be up to them. > > >

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2019-05-28 Thread Jean Delvare
On Mon, 26 Feb 2018 21:32:55 +0100, Wolfram Sang wrote: > > I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > > Therefore instructing future contributors would be up to them. > > This is really Jean's realm. Sorry for the delay. As a general rule I'm all in favor of

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2019-04-27 Thread Pali Rohár
On Wednesday 18 April 2018 13:46:10 Pali Rohár wrote: > On Thursday 08 March 2018 23:53:30 Pali Rohár wrote: > > On Monday 26 February 2018 21:32:55 Wolfram Sang wrote: > > > > > > > I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > > > > Therefore instructing future

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-04-18 Thread Pali Rohár
On Thursday 08 March 2018 23:53:30 Pali Rohár wrote: > On Monday 26 February 2018 21:32:55 Wolfram Sang wrote: > > > > > I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > > > Therefore instructing future contributors would be up to them. > > > > This is really Jean's realm. >

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-04-18 Thread Pali Rohár
On Thursday 08 March 2018 23:53:30 Pali Rohár wrote: > On Monday 26 February 2018 21:32:55 Wolfram Sang wrote: > > > > > I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > > > Therefore instructing future contributors would be up to them. > > > > This is really Jean's realm. >

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-03-08 Thread Pali Rohár
On Monday 26 February 2018 21:32:55 Wolfram Sang wrote: > > > I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > > Therefore instructing future contributors would be up to them. > > This is really Jean's realm. > Jean, ping. -- Pali Rohár pali.ro...@gmail.com

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-03-08 Thread Pali Rohár
On Monday 26 February 2018 21:32:55 Wolfram Sang wrote: > > > I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > > Therefore instructing future contributors would be up to them. > > This is really Jean's realm. > Jean, ping. -- Pali Rohár pali.ro...@gmail.com

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-26 Thread Wolfram Sang
> I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > Therefore instructing future contributors would be up to them. This is really Jean's realm. signature.asc Description: PGP signature

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-26 Thread Wolfram Sang
> I'm not maintainer of i2c-i801.ko, Jean Delvare & Wolfram Sang are. > Therefore instructing future contributors would be up to them. This is really Jean's realm. signature.asc Description: PGP signature

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 7:01 PM, Andy Shevchenko wrote: > Similar approach is used in spi-pxa2xx.c (check > pxa2xx_spi_pci_compound_match). Another approach might be a registration of I2C board info from dell-smo8800.c. Not sure if it better, because theoretically

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 7:01 PM, Andy Shevchenko wrote: > Similar approach is used in spi-pxa2xx.c (check > pxa2xx_spi_pci_compound_match). Another approach might be a registration of I2C board info from dell-smo8800.c. Not sure if it better, because theoretically user may disable that one,

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 6:50 PM, Pali Rohár wrote: > On Tuesday 13 February 2018 17:06:19 Andy Shevchenko wrote: >> On Tue, Feb 13, 2018 at 5:00 PM, Pali Rohár wrote: >> > On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: >> >> On Mon, Feb

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 6:50 PM, Pali Rohár wrote: > On Tuesday 13 February 2018 17:06:19 Andy Shevchenko wrote: >> On Tue, Feb 13, 2018 at 5:00 PM, Pali Rohár wrote: >> > On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: >> >> On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: >> >>

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Pali Rohár
On Tuesday 13 February 2018 17:06:19 Andy Shevchenko wrote: > On Tue, Feb 13, 2018 at 5:00 PM, Pali Rohár wrote: > > On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: > >> On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: > >> > On Wednesday

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Pali Rohár
On Tuesday 13 February 2018 17:06:19 Andy Shevchenko wrote: > On Tue, Feb 13, 2018 at 5:00 PM, Pali Rohár wrote: > > On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: > >> On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: > >> > On Wednesday 31 January 2018 14:27:51 Andy Shevchenko

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 5:00 PM, Pali Rohár wrote: > On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: >> On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: >> > On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: >> >> On Wed, Jan

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Tue, Feb 13, 2018 at 5:00 PM, Pali Rohár wrote: > On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: >> On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: >> > On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: >> >> On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: >> >>

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Pali Rohár
On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: > On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: > > On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: > >> On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: > >> > On Sunday

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Pali Rohár
On Tuesday 13 February 2018 16:55:00 Andy Shevchenko wrote: > On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: > > On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: > >> On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: > >> > On Sunday 28 January 2018 17:00:35 Andy Shevchenko

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: > On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: >> On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: >> > On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: >> >> On Sun, Jan 28,

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-13 Thread Andy Shevchenko
On Mon, Feb 12, 2018 at 5:30 PM, Pali Rohár wrote: > On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: >> On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: >> > On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: >> >> On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: >> >>

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-12 Thread Pali Rohár
On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: > On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: > > On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: > >> On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: > > >> > ACPI

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-12 Thread Pali Rohár
On Wednesday 31 January 2018 14:27:51 Andy Shevchenko wrote: > On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: > > On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: > >> On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: > > >> > ACPI device name is SMO8800, SMO8810, ... Will that

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-12 Thread Andy Shevchenko
On Mon, Feb 12, 2018 at 12:03 AM, Michał Kępień wrote: >> Signed-off-by: Pali Rohár >> --- >> Changes since v1: >> * Added Dell Vostro V131 based on Michał Kępień testing > > I tested this patch on a Vostro V131 and it seems to work as expected: >

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-12 Thread Andy Shevchenko
On Mon, Feb 12, 2018 at 12:03 AM, Michał Kępień wrote: >> Signed-off-by: Pali Rohár >> --- >> Changes since v1: >> * Added Dell Vostro V131 based on Michał Kępień testing > > I tested this patch on a Vostro V131 and it seems to work as expected: > "lis3lv02d: 8 bits sensor found" is logged

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-11 Thread Michał Kępień
> Dell platform team told us that some (DMI whitelisted) Dell Latitude > machines have ST microelectronics accelerometer at i2c address 0x29. > > Presence of that ST microelectronics accelerometer is verified by existence > of SMO88xx ACPI device which represent that accelerometer. Unfortunately

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-02-11 Thread Michał Kępień
> Dell platform team told us that some (DMI whitelisted) Dell Latitude > machines have ST microelectronics accelerometer at i2c address 0x29. > > Presence of that ST microelectronics accelerometer is verified by existence > of SMO88xx ACPI device which represent that accelerometer. Unfortunately

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-31 Thread Andy Shevchenko
On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: > On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: >> On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: >> > ACPI device name is SMO8800, SMO8810, ... Will that acpi_dev_present >> >

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-31 Thread Andy Shevchenko
On Wed, Jan 31, 2018 at 2:03 PM, Pali Rohár wrote: > On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: >> On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: >> > ACPI device name is SMO8800, SMO8810, ... Will that acpi_dev_present >> > function match only prefix and not exact string? >>

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-31 Thread Pali Rohár
On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: > On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: > > On Sunday 28 January 2018 16:39:25 Andy Shevchenko wrote: > >> On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: > >> > +static bool

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-31 Thread Pali Rohár
On Sunday 28 January 2018 17:00:35 Andy Shevchenko wrote: > On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: > > On Sunday 28 January 2018 16:39:25 Andy Shevchenko wrote: > >> On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: > >> > +static bool is_dell_system_with_lis3lv02d(void) > >> > +{ >

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-28 Thread Andy Shevchenko
On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: > On Sunday 28 January 2018 16:39:25 Andy Shevchenko wrote: >> On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: >> > +static bool is_dell_system_with_lis3lv02d(void) >> > +{ >> >> > + /* >> > +

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-28 Thread Andy Shevchenko
On Sun, Jan 28, 2018 at 4:45 PM, Pali Rohár wrote: > On Sunday 28 January 2018 16:39:25 Andy Shevchenko wrote: >> On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: >> > +static bool is_dell_system_with_lis3lv02d(void) >> > +{ >> >> > + /* >> > +* Check that ACPI device SMO88xx

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-28 Thread Pali Rohár
On Sunday 28 January 2018 16:39:25 Andy Shevchenko wrote: > On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: > > +static bool is_dell_system_with_lis3lv02d(void) > > +{ > > > + /* > > +* Check that ACPI device SMO88xx exists and is enabled. That ACPI > > +

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-28 Thread Pali Rohár
On Sunday 28 January 2018 16:39:25 Andy Shevchenko wrote: > On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: > > +static bool is_dell_system_with_lis3lv02d(void) > > +{ > > > + /* > > +* Check that ACPI device SMO88xx exists and is enabled. That ACPI > > +* device

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-28 Thread Andy Shevchenko
On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: > Dell platform team told us that some (DMI whitelisted) Dell Latitude > machines have ST microelectronics accelerometer at i2c address 0x29. > > Presence of that ST microelectronics accelerometer is verified by existence >

Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-28 Thread Andy Shevchenko
On Sat, Jan 27, 2018 at 3:32 PM, Pali Rohár wrote: > Dell platform team told us that some (DMI whitelisted) Dell Latitude > machines have ST microelectronics accelerometer at i2c address 0x29. > > Presence of that ST microelectronics accelerometer is verified by existence > of SMO88xx ACPI device

[PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-27 Thread Pali Rohár
Dell platform team told us that some (DMI whitelisted) Dell Latitude machines have ST microelectronics accelerometer at i2c address 0x29. Presence of that ST microelectronics accelerometer is verified by existence of SMO88xx ACPI device which represent that accelerometer. Unfortunately ACPI

[PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2018-01-27 Thread Pali Rohár
Dell platform team told us that some (DMI whitelisted) Dell Latitude machines have ST microelectronics accelerometer at i2c address 0x29. Presence of that ST microelectronics accelerometer is verified by existence of SMO88xx ACPI device which represent that accelerometer. Unfortunately ACPI