Re: [PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-31 Thread Avi Fishman
Please ignore my last mail, Tali already sent v3. On Mon, Aug 31, 2020 at 10:57 AM Avi Fishman wrote: > > On Sun, Aug 30, 2020 at 9:01 PM Andy Shevchenko > wrote: > > > > On Sun, Aug 30, 2020 at 3:23 PM Tali Perry wrote: > > > > > > > > i2c: npcm7xx: bug fix timeout (usec instead of msec) > > >

Re: [PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-31 Thread Avi Fishman
On Sun, Aug 30, 2020 at 9:01 PM Andy Shevchenko wrote: > > On Sun, Aug 30, 2020 at 3:23 PM Tali Perry wrote: > > > > > i2c: npcm7xx: bug fix timeout (usec instead of msec) > > This commit message is awful. Please read [1] as a tutorial how to > write a commit messages. > Would this be better: i2

Re: [PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-30 Thread Andy Shevchenko
On Sun, Aug 30, 2020 at 3:23 PM Tali Perry wrote: > > i2c: npcm7xx: bug fix timeout (usec instead of msec) This commit message is awful. Please read [1] as a tutorial how to write a commit messages. [1]: https://chris.beams.io/posts/git-commit/ ... > - /* Adaptive TimeOut: astimated tim

Re: [PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-30 Thread Avi Fishman
On Sun, Aug 30, 2020 at 3:21 PM Tali Perry wrote: > > i2c: npcm7xx: bug fix timeout (usec instead of msec) > > Signed-off-by: Tali Perry Reviewed-by: Avi Fishman > --- > drivers/i2c/busses/i2c-npcm7xx.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/i

[PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-30 Thread Tali Perry
i2c: npcm7xx: bug fix timeout (usec instead of msec) Signed-off-by: Tali Perry --- drivers/i2c/busses/i2c-npcm7xx.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index 75f07138a6fa..abb334492a3d 10