Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-24 Thread Geert Uytterhoeven
Hi Finn, On Thu, Sep 24, 2020 at 3:07 AM Finn Thain wrote: > On Wed, 16 Sep 2020, Finn Thain wrote: > > On Tue, 15 Sep 2020, Geert Uytterhoeven wrote: > > > > > > --- a/drivers/ide/macide.c > > > > > > +++ b/drivers/ide/macide.c > > > > > > > > > > > @@ -109,42 +110,61 @@ static const char *mac_i

Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-23 Thread Michael Schmitz
Hi Finn, On 24/09/20 1:07 PM, Finn Thain wrote: Looking further at the drivers using ide_host_register(), I see that falconide.c is missing a set_drvdata() call, while tx4939ide.c calls set_drvdata() after ide_host_register(). The latter example is not a bug. The pattern I used, that is, callin

Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-23 Thread Finn Thain
Hi Geert, On Wed, 16 Sep 2020, Finn Thain wrote: > On Tue, 15 Sep 2020, Geert Uytterhoeven wrote: > > > > > > --- a/drivers/ide/macide.c > > > > > +++ b/drivers/ide/macide.c > > > > > > > > > @@ -109,42 +110,61 @@ static const char *mac_ide_name[] = > > > > > * Probe for a Macintosh IDE interf

Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-15 Thread Finn Thain
On Tue, 15 Sep 2020, Geert Uytterhoeven wrote: > > > > --- a/drivers/ide/macide.c > > > > +++ b/drivers/ide/macide.c > > > > > > > @@ -109,42 +110,61 @@ static const char *mac_ide_name[] = > > > > * Probe for a Macintosh IDE interface > > > > */ > > > > > > > > -static int __init macide_init(v

Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-15 Thread Geert Uytterhoeven
Hi Finn, On Tue, Sep 15, 2020 at 3:17 AM Finn Thain wrote: > On Mon, 14 Sep 2020, Geert Uytterhoeven wrote: > > On Mon, Sep 14, 2020 at 4:47 AM Finn Thain > > wrote: > > > Add platform devices for the Mac IDE controller variants. Convert the > > > macide module into a platform driver to support

Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-14 Thread Finn Thain
On Mon, 14 Sep 2020, Geert Uytterhoeven wrote: > Hi Finn, > > On Mon, Sep 14, 2020 at 4:47 AM Finn Thain wrote: > > Add platform devices for the Mac IDE controller variants. Convert the > > macide module into a platform driver to support two of those variants. > > For the third, use a generic "p

Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-14 Thread Geert Uytterhoeven
Hi Finn, On Mon, Sep 14, 2020 at 4:47 AM Finn Thain wrote: > Add platform devices for the Mac IDE controller variants. Convert the > macide module into a platform driver to support two of those variants. > For the third, use a generic "pata_platform" driver instead. > This enables automatic loadi

[PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

2020-09-13 Thread Finn Thain
Add platform devices for the Mac IDE controller variants. Convert the macide module into a platform driver to support two of those variants. For the third, use a generic "pata_platform" driver instead. This enables automatic loading of the appropriate module and begins the process of replacing the