RE: [PATCH v2] iio: adc: add new lp8788 adc driver

2012-08-15 Thread Jonathan Cameron
"Kim, Milo" wrote: >> > + switch (mask) { >> > + case IIO_CHAN_INFO_RAW: >> > + *val = result; >> > + return IIO_VAL_INT; >> > + case IIO_CHAN_INFO_SCALE: >> > + *val = adc_const[id] * ((result * 1000 + 500) / 1000); >> >> This looks wrong. The IIO_CHAN_INFO_SCALE

RE: [PATCH v2] iio: adc: add new lp8788 adc driver

2012-08-15 Thread Kim, Milo
> > + switch (mask) { > > + case IIO_CHAN_INFO_RAW: > > + *val = result; > > + return IIO_VAL_INT; > > + case IIO_CHAN_INFO_SCALE: > > + *val = adc_const[id] * ((result * 1000 + 500) / 1000); > > This looks wrong. The IIO_CHAN_INFO_SCALE attribute is the factor

Re: [PATCH v2] iio: adc: add new lp8788 adc driver

2012-08-15 Thread Lars-Peter Clausen
On 08/10/2012 09:06 AM, Kim, Milo wrote: > [...] > + switch (mask) { > + case IIO_CHAN_INFO_RAW: > + *val = result; > + return IIO_VAL_INT; > + case IIO_CHAN_INFO_SCALE: > + *val = adc_const[id] * ((result * 1000 + 500) / 1000); This looks wrong. The

Re: [PATCH v2] iio: adc: add new lp8788 adc driver

2012-08-14 Thread Jonathan Cameron
On 08/10/2012 08:06 AM, Kim, Milo wrote: > Patch v2. > (a) Use iio_priv() for private data rather than allocating data > (b) Support raw and scale inferface for iio consumer > (c) Make inline function for lp8788_adc_read_raw() > (d) For better readability, use fixed number for shift and mask >

[PATCH v2] iio: adc: add new lp8788 adc driver

2012-08-10 Thread Kim, Milo
Patch v2. (a) Use iio_priv() for private data rather than allocating data (b) Support raw and scale inferface for iio consumer (c) Make inline function for lp8788_adc_read_raw() (d) For better readability, use fixed number for shift and mask rather than getting bits from channel scan type (e) C