Re: [PATCH v2] iio: light: add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors

2015-04-26 Thread Jonathan Cameron
On 26/04/15 19:41, tdusz...@gmail.com wrote: > On Sun, Apr 26, 2015 at 05:50:02PM +0100, Jonathan Cameron wrote: >> On 25/04/15 15:18, Tomasz Duszynski wrote: >>> Add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light >>> sensors. >>> >>> Signed-off-by: Tomasz Duszynski >> On query

Re: [PATCH v2] iio: light: add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors

2015-04-26 Thread tduszyns
On Sun, Apr 26, 2015 at 05:50:02PM +0100, Jonathan Cameron wrote: > On 25/04/15 15:18, Tomasz Duszynski wrote: > > Add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light > > sensors. > > > > Signed-off-by: Tomasz Duszynski > On query on why we no longer have a resume function... Oth

Re: [PATCH v2] iio: light: add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors

2015-04-26 Thread Jonathan Cameron
On 25/04/15 15:18, Tomasz Duszynski wrote: > Add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light > sensors. > > Signed-off-by: Tomasz Duszynski On query on why we no longer have a resume function... Otherwise looks pretty good to me (couple of other comments inline.) Jonathan >

[PATCH v2] iio: light: add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors

2015-04-25 Thread Tomasz Duszynski
Add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors. Signed-off-by: Tomasz Duszynski --- Changes in v2: - Store chip-dependent values in chip_info structure - Add bh1750_remove to power down chip (necessary for BH1721) - Use one time mode for chi