Re: [PATCH v2] include/linux/module.h: mark init/cleanup_module aliases as __init/exit

On Thu, Feb 7, 2019 at 11:54 AM Jessica Yu wrote: > > My order of preference would be 2, 1, striving for 3 eventually. For reference, for 3), we would need to tweak the following ~130 modules [1]. Quite a lot of them are the simple kind. Also, if we end up with 3), we could potentially remove a f

Re: [PATCH v2] include/linux/module.h: mark init/cleanup_module aliases as __init/exit

+++ Miguel Ojeda [06/02/19 22:19 +0100]: On Wed, Feb 6, 2019 at 6:56 PM Miguel Ojeda wrote: diff --git a/include/linux/module.h b/include/linux/module.h index 8fa38d3e7538..1b5e370f1bc0 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -129,13 +129,13 @@ extern void cleanup_m

Re: [PATCH v2] include/linux/module.h: mark init/cleanup_module aliases as __init/exit

On Wed, Feb 6, 2019 at 6:56 PM Miguel Ojeda wrote: > > diff --git a/include/linux/module.h b/include/linux/module.h > index 8fa38d3e7538..1b5e370f1bc0 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -129,13 +129,13 @@ extern void cleanup_module(void); > #define module_in

[PATCH v2] include/linux/module.h: mark init/cleanup_module aliases as __init/exit

The upcoming GCC 9 release extends the -Wmissing-attributes warnings (enabled by -Wall) to C and aliases: it warns when particular function attributes are missing in the aliases but not in their target. In particular, it triggers for all the init/cleanup_module aliases in the kernel (defined by th