[PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
We can't seem to have a kernel with CONFIG_EXPERT set but CONFIG_DEBUG_KERNEL unset these days. While some of the features under the CONFIG_EXPERT require CONFIG_DEBUG_KERNEL, it doesn't apply for all features. It looks like CONFIG_KALLSYMS_ALL is the only feature that requires CONFIG_DEBUG_KERNE

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya wrote: > > We can't seem to have a kernel with CONFIG_EXPERT set but > CONFIG_DEBUG_KERNEL unset these days. > > While some of the features under the CONFIG_EXPERT require > CONFIG_DEBUG_KERNEL, it doesn't apply for all features. > > It looks like CONFIG_

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Josh Triplett
On April 10, 2019 3:58:55 PM PDT, Kees Cook wrote: >On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya wrote: >> >> We can't seem to have a kernel with CONFIG_EXPERT set but >> CONFIG_DEBUG_KERNEL unset these days. >> >> While some of the features under the CONFIG_EXPERT require >> CONFIG_DEBUG_KERNEL, i

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett wrote: > > On April 10, 2019 3:58:55 PM PDT, Kees Cook wrote: > >On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya wrote: > >> > >> We can't seem to have a kernel with CONFIG_EXPERT set but > >> CONFIG_DEBUG_KERNEL unset these days. > >> > >> While some of

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Josh Triplett
On April 10, 2019 4:24:18 PM PDT, Kees Cook wrote: >On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett >wrote: >> >> On April 10, 2019 3:58:55 PM PDT, Kees Cook >wrote: >> >On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya wrote: >> >> >> >> We can't seem to have a kernel with CONFIG_EXPERT set but >> >> C

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
On 4/10/2019 11:02 PM, Josh Triplett wrote: Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this. I think we have to do both. We need to go after the users as well as solve the immediate problem per this patch

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Randy Dunlap
On 4/10/19 8:02 PM, Josh Triplett wrote: > On April 10, 2019 4:24:18 PM PDT, Kees Cook wrote: >> On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett >> wrote: >>> >>> On April 10, 2019 3:58:55 PM PDT, Kees Cook >> wrote: On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya wrote: > > We can't seem

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-11 Thread Josh Triplett
On Wed, Apr 10, 2019 at 11:13:52PM -0400, Sinan Kaya wrote: > On 4/10/2019 11:02 PM, Josh Triplett wrote: > > Then let's fix*that*, and get checkpatch to help enforce it in the future. > > EXPERT doesn't affect code generation, and neither should this. > > I think we have to do both. We need to g

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-11 Thread Kees Cook
On Thu, Apr 11, 2019 at 3:16 PM Josh Triplett wrote: > > On Wed, Apr 10, 2019 at 11:13:52PM -0400, Sinan Kaya wrote: > > On 4/10/2019 11:02 PM, Josh Triplett wrote: > > > Then let's fix*that*, and get checkpatch to help enforce it in the > > > future. EXPERT doesn't affect code generation, and ne

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-11 Thread Sinan Kaya
On 4/11/2019 6:21 PM, Kees Cook wrote: Proposed alternative plan: let's add a new symbol, something like DEBUG_MISC ("Miscellaneous debug code that should be under a more specific debug option but isn't"), make it depend on DEBUG_KERNEL and be "default DEBUG_KERNEL" but allow itself to be turned

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-11 Thread Josh Triplett
On Thu, Apr 11, 2019 at 06:27:04PM -0400, Sinan Kaya wrote: > On 4/11/2019 6:21 PM, Kees Cook wrote: > > > Proposed alternative plan: let's add a new symbol, something like > > > DEBUG_MISC ("Miscellaneous debug code that should be under a more > > > specific debug option but isn't"), make it depen