Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread David Miller
From: 严海双 Date: Tue, 24 May 2016 11:55:31 +0800 > >> On May 24, 2016, at 11:14 AM, Eric Dumazet wrote: >> >> On Tue, 2016-05-24 at 10:39 +0800, Haishuang Yan wrote: >>> For ipv6 case, enclose the code block in macro

Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread David Miller
From: 严海双 Date: Tue, 24 May 2016 11:55:31 +0800 > >> On May 24, 2016, at 11:14 AM, Eric Dumazet wrote: >> >> On Tue, 2016-05-24 at 10:39 +0800, Haishuang Yan wrote: >>> For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6). >>> >>> --- >>> Changes in v2: >>> - Place the

Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread 严海双
> On May 24, 2016, at 11:14 AM, Eric Dumazet wrote: > > On Tue, 2016-05-24 at 10:39 +0800, Haishuang Yan wrote: >> For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6). >> >> --- >> Changes in v2: >> - Place the "#if IS_ENABLED" block before the "}

Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread 严海双
> On May 24, 2016, at 11:14 AM, Eric Dumazet wrote: > > On Tue, 2016-05-24 at 10:39 +0800, Haishuang Yan wrote: >> For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6). >> >> --- >> Changes in v2: >> - Place the "#if IS_ENABLED" block before the "} else if >> (..) {" piece

Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread Eric Dumazet
On Tue, 2016-05-24 at 10:39 +0800, Haishuang Yan wrote: > For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6). > > --- > Changes in v2: > - Place the "#if IS_ENABLED" block before the "} else if > (..) {" piece and the "#endif" before the closing brace and this > becomes much

Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread Eric Dumazet
On Tue, 2016-05-24 at 10:39 +0800, Haishuang Yan wrote: > For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6). > > --- > Changes in v2: > - Place the "#if IS_ENABLED" block before the "} else if > (..) {" piece and the "#endif" before the closing brace and this > becomes much

[PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread Haishuang Yan
For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6). --- Changes in v2: - Place the "#if IS_ENABLED" block before the "} else if (..) {" piece and the "#endif" before the closing brace and this becomes much easier to look at. Signed-off-by: Haishuang Yan

[PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

2016-05-23 Thread Haishuang Yan
For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6). --- Changes in v2: - Place the "#if IS_ENABLED" block before the "} else if (..) {" piece and the "#endif" before the closing brace and this becomes much easier to look at. Signed-off-by: Haishuang Yan ---