On 08/26, Cyrill Gorcunov wrote:
>
> On Mon, Aug 25, 2014 at 09:12:07PM +0200, Oleg Nesterov wrote:
> > + vma = find_vma(current->mm, addr);
> > + if (vma) {
> > + unsigned long end = addr + size;
> > +
> > + if (vma->vm_flags & VM_GROWSDOWN)
On 08/25, Hugh Dickins wrote:
>
> On Mon, 25 Aug 2014, Oleg Nesterov wrote:
>
> >As Hugh pointed out, we actually need to require the additional
> >guard page, but this code was written before linux had it.
> >
> > 3. This wrongly assumes that the stack can only grown down.
> >
> > Personal
On Mon, 25 Aug 2014, Oleg Nesterov wrote:
> The ->start_stack check in do_shmat() looks ugly and simply wrong.
>
> 1. ->start_stack is only valid right after exec(), the application
>can switch to another stack and even unmap this area. Or a stack
>can simply grow, ->start_stack won't eve
On Mon, Aug 25, 2014 at 09:12:07PM +0200, Oleg Nesterov wrote:
> + vma = find_vma(current->mm, addr);
> + if (vma) {
> + unsigned long end = addr + size;
> +
> + if (vma->vm_flags & VM_GROWSDOWN)
> + end +=
The ->start_stack check in do_shmat() looks ugly and simply wrong.
1. ->start_stack is only valid right after exec(), the application
can switch to another stack and even unmap this area. Or a stack
can simply grow, ->start_stack won't even notice this.
2. The reason for this check is not c
5 matches
Mail list logo