Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-14 Thread 严海双
> On 2017年9月13日, at 下午9:02, Eric Dumazet wrote: > > On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: >> On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: >>> Different namespace application might require enable TCP Fast Open >>> feature independently of the

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-14 Thread 严海双
> On 2017年9月13日, at 下午9:02, Eric Dumazet wrote: > > On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: >> On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: >>> Different namespace application might require enable TCP Fast Open >>> feature independently of the host. >>> >> >> Poor

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: > On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: > > Different namespace application might require enable TCP Fast Open > > feature independently of the host. > > > > Poor changelog, no actual description / list of sysctls that are

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: > On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: > > Different namespace application might require enable TCP Fast Open > > feature independently of the host. > > > > Poor changelog, no actual description / list of sysctls that are

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: > Different namespace application might require enable TCP Fast Open > feature independently of the host. > Poor changelog, no actual description / list of sysctls that are moved to per netns. And looking at the patch, it seems your

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: > Different namespace application might require enable TCP Fast Open > feature independently of the host. > Poor changelog, no actual description / list of sysctls that are moved to per netns. And looking at the patch, it seems your

[PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Haishuang Yan
Different namespace application might require enable TCP Fast Open feature independently of the host. Reported-by: Luca BRUNO Signed-off-by: Haishuang Yan --- Change since v2: * Remove unrelated change by mistake ---

[PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Haishuang Yan
Different namespace application might require enable TCP Fast Open feature independently of the host. Reported-by: Luca BRUNO Signed-off-by: Haishuang Yan --- Change since v2: * Remove unrelated change by mistake --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 -