Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-19 Thread David Miller
From: Denys Vlasenko Date: Sun, 19 Jul 2015 17:14:53 +0200 > On 07/16/2015 08:17 PM, David Miller wrote: >> From: Tom Herbert >> Date: Thu, 16 Jul 2015 08:43:25 -0700 >> >>> On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote: This patch deinlines jhash, jhash2 and __jhash_nwords.

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-19 Thread Denys Vlasenko
On 07/16/2015 08:17 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 16 Jul 2015 08:43:25 -0700 > >> On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote: >>> This patch deinlines jhash, jhash2 and __jhash_nwords. >>> >>> It also removes rhashtable_jhash2(key, length, seed) >>> because

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 15:44 +0200, Hagen Paul Pfeifer wrote: > > On July 16, 2015 at 9:23 PM Joe Perches wrote: > > > > It might be useful to have these performance impacting > > changes guarded by something like CONFIG_CC_OPTIMIZE_FOR_SIZE > > with another static __always_inline __ and a functio

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-17 Thread Hagen Paul Pfeifer
> On July 16, 2015 at 9:23 PM Joe Perches wrote: > > It might be useful to have these performance impacting > changes guarded by something like CONFIG_CC_OPTIMIZE_FOR_SIZE > with another static __always_inline __ and a function & > EXPORT_SYMBOL or just a static inline so that where code size > i

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-16 Thread Joe Perches
On Thu, 2015-07-16 at 11:17 -0700, David Miller wrote: > From: Tom Herbert > Date: Thu, 16 Jul 2015 08:43:25 -0700 > > > On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote: > >> This patch deinlines jhash, jhash2 and __jhash_nwords. > >> > >> It also removes rhashtable_jhash2(key, length, see

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-16 Thread David Miller
From: Tom Herbert Date: Thu, 16 Jul 2015 08:43:25 -0700 > On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote: >> This patch deinlines jhash, jhash2 and __jhash_nwords. >> >> It also removes rhashtable_jhash2(key, length, seed) >> because it was merely calling jhash2(key, length, seed). >> >>

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-16 Thread Tom Herbert
On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote: > This patch deinlines jhash, jhash2 and __jhash_nwords. > > It also removes rhashtable_jhash2(key, length, seed) > because it was merely calling jhash2(key, length, seed). > > With this .config: http://busybox.net/~vda/kernel_config, > after

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-16 Thread Alexander Duyck
On 07/16/2015 05:40 AM, Denys Vlasenko wrote: This patch deinlines jhash, jhash2 and __jhash_nwords. It also removes rhashtable_jhash2(key, length, seed) because it was merely calling jhash2(key, length, seed). With this .config: http://busybox.net/~vda/kernel_config, after deinlining these fun

[PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-16 Thread Denys Vlasenko
This patch deinlines jhash, jhash2 and __jhash_nwords. It also removes rhashtable_jhash2(key, length, seed) because it was merely calling jhash2(key, length, seed). With this .config: http://busybox.net/~vda/kernel_config, after deinlining these functions have sizes and callsite counts as follows