Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-28 Thread Masahiro Yamada
On Tue, Jul 23, 2019 at 5:17 PM Thomas Gleixner wrote: > > On Tue, 23 Jul 2019, Thomas Gleixner wrote: > > On Tue, 23 Jul 2019, Masahiro Yamada wrote: > > > Right. > > > I was able to build with ld.gold > > > > > > So, we can use gold, depending on the kernel configuration. > > > > That's exactly

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-23 Thread Thomas Gleixner
On Tue, 23 Jul 2019, Thomas Gleixner wrote: > On Tue, 23 Jul 2019, Masahiro Yamada wrote: > > Right. > > I was able to build with ld.gold > > > > So, we can use gold, depending on the kernel configuration. > > That's exactly the problem. It breaks with random kernel configurations > which is not

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-23 Thread Thomas Gleixner
On Tue, 23 Jul 2019, Masahiro Yamada wrote: > Right. > I was able to build with ld.gold > > So, we can use gold, depending on the kernel configuration. That's exactly the problem. It breaks with random kernel configurations which is not acceptable except for people who know what they are doing.

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-22 Thread Masahiro Yamada
On Sat, Jul 20, 2019 at 6:12 PM Mike Lothian wrote: > > On Wed, 17 Jul 2019 at 08:57, Thomas Gleixner wrote: > > > > On Wed, 17 Jul 2019, Masahiro Yamada wrote: > > > On Wed, Jul 17, 2019 at 4:47 AM Thomas Gleixner > > > wrote: > > > > So instead of dealing with attempts to duct tape gold

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-20 Thread Mike Lothian
On Sat, 20 Jul 2019 at 11:54, Thomas Gleixner wrote: > > On Sat, 20 Jul 2019, Mike Lothian wrote: > > Here is my config > > > > https://github.com/FireBurn/KernelStuff/blob/9b7e96581598d50b266f9df258e7de764949147a/dot_config_tip > > > > Builds perfectly fine. Sorry top posted from my phone Are

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-20 Thread Thomas Gleixner
On Sat, 20 Jul 2019, Mike Lothian wrote: > Here is my config > > https://github.com/FireBurn/KernelStuff/blob/9b7e96581598d50b266f9df258e7de764949147a/dot_config_tip > Builds perfectly fine.

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-20 Thread Mike Lothian
On Sat, 20 Jul 2019 at 10:34, Thomas Gleixner wrote: > > On Sat, 20 Jul 2019, Mike Lothian wrote: > > On Wed, 17 Jul 2019 at 08:57, Thomas Gleixner wrote: > > I've done a bit more digging, I had a second machine that was building > > Linus's tree just fine with ld.gold > > > > I tried forcing

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-20 Thread Thomas Gleixner
On Sat, 20 Jul 2019, Mike Lothian wrote: > On Wed, 17 Jul 2019 at 08:57, Thomas Gleixner wrote: > I've done a bit more digging, I had a second machine that was building > Linus's tree just fine with ld.gold > > I tried forcing ld.bfd on the problem machine and got this: > > ld.bfd:

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-20 Thread Mike Lothian
On Wed, 17 Jul 2019 at 08:57, Thomas Gleixner wrote: > > On Wed, 17 Jul 2019, Masahiro Yamada wrote: > > On Wed, Jul 17, 2019 at 4:47 AM Thomas Gleixner wrote: > > > So instead of dealing with attempts to duct tape gold support without > > > understanding the root cause and without support from

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-17 Thread Thomas Gleixner
On Wed, 17 Jul 2019, Masahiro Yamada wrote: > On Wed, Jul 17, 2019 at 4:47 AM Thomas Gleixner wrote: > > So instead of dealing with attempts to duct tape gold support without > > understanding the root cause and without support from the gold folks, fail > > the build when gold is detected. > > >

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-17 Thread Masahiro Yamada
On Wed, Jul 17, 2019 at 4:47 AM Thomas Gleixner wrote: > > The gold linker has known issues of failing the build both in random and in > predictible ways: > > - The x86/X32 VDSO build fails with: > >arch/x86/entry/vdso/vclock_gettime-x32.o:vclock_gettime.c:function do_hres: >error:

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-16 Thread Theodore Y. Ts'o
On Wed, Jul 17, 2019 at 12:25:14AM +0200, Thomas Gleixner wrote: > > It's been my default system linker for years and I've had very few issues > > with it and it's a big improvement when linking with LTO > > I understand, but the fact that you need to turn off config options in > order to build a

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-16 Thread Thomas Gleixner
Mike, On Tue, 16 Jul 2019, Mike Lothian wrote: > On Tue, 16 Jul 2019 at 21:00, Nathan Chancellor wrote > > Would it be possible to force ld.bfd with -fuse-ld=bfd when gold is detected? It's probably possible but way beyond my kbuild foo. Adding LD=ld.bfd to the make invocation is the trivial

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-16 Thread Mike Lothian
On Tue, 16 Jul 2019 at 21:00, Nathan Chancellor wrote: > > On Tue, Jul 16, 2019 at 09:47:27PM +0200, Thomas Gleixner wrote: > > The gold linker has known issues of failing the build both in random and in > > predictible ways: > > > > - The x86/X32 VDSO build fails with: > > > >

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-16 Thread Nathan Chancellor
On Tue, Jul 16, 2019 at 09:47:27PM +0200, Thomas Gleixner wrote: > The gold linker has known issues of failing the build both in random and in > predictible ways: > > - The x86/X32 VDSO build fails with: > >arch/x86/entry/vdso/vclock_gettime-x32.o:vclock_gettime.c:function do_hres: >

[PATCH v2] kbuild: Fail if gold linker is detected

2019-07-16 Thread Thomas Gleixner
The gold linker has known issues of failing the build both in random and in predictible ways: - The x86/X32 VDSO build fails with: arch/x86/entry/vdso/vclock_gettime-x32.o:vclock_gettime.c:function do_hres: error: relocation overflow: reference to 'hvclock_page' That's a known issue