Re: [PATCH v2] kbuild: fix if_change and friends to consider argument order

2016-05-10 Thread Michal Marek
On Sat, May 07, 2016 at 03:48:26PM +0900, Masahiro Yamada wrote: > Currently, arg-check is implemented as follows: > > arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \ > $(filter-out $(cmd_$@), $(cmd_$(1))) ) > > This does not care about the order of arguments

Re: [PATCH v2] kbuild: fix if_change and friends to consider argument order

2016-05-10 Thread Michal Marek
On Sat, May 07, 2016 at 03:48:26PM +0900, Masahiro Yamada wrote: > Currently, arg-check is implemented as follows: > > arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \ > $(filter-out $(cmd_$@), $(cmd_$(1))) ) > > This does not care about the order of arguments

[PATCH v2] kbuild: fix if_change and friends to consider argument order

2016-05-07 Thread Masahiro Yamada
Currently, arg-check is implemented as follows: arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \ $(filter-out $(cmd_$@), $(cmd_$(1))) ) This does not care about the order of arguments that appear in $(cmd_$(1)) and $(cmd_$@). So, if_changed and friends never

[PATCH v2] kbuild: fix if_change and friends to consider argument order

2016-05-07 Thread Masahiro Yamada
Currently, arg-check is implemented as follows: arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \ $(filter-out $(cmd_$@), $(cmd_$(1))) ) This does not care about the order of arguments that appear in $(cmd_$(1)) and $(cmd_$@). So, if_changed and friends never