Re: [PATCH v2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-31 Thread Miguel Ojeda
On Thu, Aug 29, 2019 at 8:13 PM Masahiro Yamada wrote: > > +# W=1 - warnings that may be relevant and does not occur too often s/does/do/ Acked-by: Miguel Ojeda Cheers, Miguel

Re: [PATCH v2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-30 Thread Nick Desaulniers
On Thu, Aug 29, 2019 at 11:12 AM Masahiro Yamada wrote: > > Instead of the warning-[123] magic, let's accumulate compiler options > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > easier to understand what is going on in this file. > > This commit slightly changes the beha

Re: [PATCH v2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-29 Thread Sedat Dilek
On Thu, Aug 29, 2019 at 8:13 PM Masahiro Yamada wrote: > > Instead of the warning-[123] magic, let's accumulate compiler options > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > easier to understand what is going on in this file. > > This commit slightly changes the behav

Re: [PATCH v2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-29 Thread Sedat Dilek
On Thu, Aug 29, 2019 at 8:13 PM Masahiro Yamada wrote: > > Instead of the warning-[123] magic, let's accumulate compiler options > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > easier to understand what is going on in this file. > > This commit slightly changes the behav

[PATCH v2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-29 Thread Masahiro Yamada
Instead of the warning-[123] magic, let's accumulate compiler options to KBUILD_CFLAGS directly as the top Makefile does. I think this makes easier to understand what is going on in this file. This commit slightly changes the behavior, I think all of which are OK. [1] Currently, cc-option calls a