Re: [PATCH v2] kdb: remove unnecessary null check of dbg_io_ops

On June 30, 2020 00:16:54 Doug Anderson wrote: Hi, On Mon, Jun 29, 2020 at 1:50 PM Cengiz Can wrote: `kdb_msg_write` operates on a global `struct kgdb_io *` called `dbg_io_ops`. It's initialized in `debug_core.c` and checked throughout the debug flow. There's a null check in

Re: [PATCH v2] kdb: remove unnecessary null check of dbg_io_ops

Hi, On Mon, Jun 29, 2020 at 1:50 PM Cengiz Can wrote: > > `kdb_msg_write` operates on a global `struct kgdb_io *` called > `dbg_io_ops`. > > It's initialized in `debug_core.c` and checked throughout the debug > flow. > > There's a null check in `kdb_msg_write` which triggers static analyzers >

[PATCH v2] kdb: remove unnecessary null check of dbg_io_ops

`kdb_msg_write` operates on a global `struct kgdb_io *` called `dbg_io_ops`. It's initialized in `debug_core.c` and checked throughout the debug flow. There's a null check in `kdb_msg_write` which triggers static analyzers and gives the (almost entirely wrong) impression that it can be null.