Re: [PATCH v2] kernel/module.c: cleanup patch for looping, let return 'bool' value instead of real error number.

2013-05-13 Thread Chen Gang
Oh, sorry, my fix is incorrect !! The return value is used by caller of caller ... it seems the user mode can sense it !! So we still should return the correct error code to outside when error occurs. I think we can reference 'using compiler': it prints all errors and warnings as far as it can,

[PATCH v2] kernel/module.c: cleanup patch for looping, let return 'bool' value instead of real error number.

2013-05-13 Thread Chen Gang
For looping in simplify_symbols(), when multiple errors occur, the original error number will be override (the original related commit "1da177e Linux-2.6.12-rc"). We focus on printing all errors as much as possible, and not focus on the return error number (only know whether succeed or not is

[PATCH v2] kernel/module.c: cleanup patch for looping, let return 'bool' value instead of real error number.

2013-05-13 Thread Chen Gang
For looping in simplify_symbols(), when multiple errors occur, the original error number will be override (the original related commit 1da177e Linux-2.6.12-rc). We focus on printing all errors as much as possible, and not focus on the return error number (only know whether succeed or not is

Re: [PATCH v2] kernel/module.c: cleanup patch for looping, let return 'bool' value instead of real error number.

2013-05-13 Thread Chen Gang
Oh, sorry, my fix is incorrect !! The return value is used by caller of caller ... it seems the user mode can sense it !! So we still should return the correct error code to outside when error occurs. I think we can reference 'using compiler': it prints all errors and warnings as far as it can,