Re: [PATCH v2] kvm tools: remove redundant "if" condition

2013-01-22 Thread Pekka Enberg
On Sat, Jan 19, 2013 at 12:27 PM, Cong Ding wrote: > On Sat, Jan 19, 2013 at 10:58:33AM +0200, Pekka Enberg wrote: >> On Wed, Jan 16, 2013 at 6:52 PM, Cong Ding wrote: >> > After we check (state.kcount != 0), state.kcount has to be 0 in all the >> > "else" >> > branchs. >> > >> > Signed-off-by:

Re: [PATCH v2] kvm tools: remove redundant "if" condition

2013-01-19 Thread Cong Ding
On Sat, Jan 19, 2013 at 10:58:33AM +0200, Pekka Enberg wrote: > On Wed, Jan 16, 2013 at 6:52 PM, Cong Ding wrote: > > After we check (state.kcount != 0), state.kcount has to be 0 in all the > > "else" > > branchs. > > > > Signed-off-by: Cong Ding > > --- > > tools/kvm/hw/i8042.c |2 +- > >

Re: [PATCH v2] kvm tools: remove redundant "if" condition

2013-01-19 Thread Pekka Enberg
On Wed, Jan 16, 2013 at 6:52 PM, Cong Ding wrote: > After we check (state.kcount != 0), state.kcount has to be 0 in all the "else" > branchs. > > Signed-off-by: Cong Ding > --- > tools/kvm/hw/i8042.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kvm/hw/i8042.c

[PATCH v2] kvm tools: remove redundant "if" condition

2013-01-16 Thread Cong Ding
After we check (state.kcount != 0), state.kcount has to be 0 in all the "else" branchs. Signed-off-by: Cong Ding --- tools/kvm/hw/i8042.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kvm/hw/i8042.c b/tools/kvm/hw/i8042.c index 9f8be6a..9035732 100644 --- a/tools/k